Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-103357

QNearFieldTargetPrivate shouldn't be a QObject

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • P3: Somewhat important
    • None
    • None
    • Connectivity: NFC
    • None
    • Team B Foundation Sprint 57, Team B Foundation Sprint 58

    Description

      QNearFieldTarget already is. It's unclear why the pimpl also needs to be. The commit that introduced this, https://codereview.qt-project.org/c/qt/qtconnectivity/+/303265, doesn't contain any discussion about it, either.

      larss do you remember?

      Acceptance criteria:

      • either port QNearFieldTargetPrivate away from QObject or
      • add a comment explaining why it has to be

      Attachments

        For Gerrit Dashboard: QTBUG-103357
        # Subject Branch Project Status CR V
        411273,2 QNearFieldTargetPrivate: Use same types in declarations and definitions dev qt/qtconnectivity Status: MERGED +2 0
        411278,2 QtNfc: Get rid of NearFieldTarget class dev qt/qtconnectivity Status: MERGED +2 0

        Activity

          People

            ievgenii.meshcheriakov Ievgenii Meshcheriakov
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes