Details
-
Task
-
Resolution: Unresolved
-
P2: Important
-
None
-
None
-
None
-
30344aaa4 (dev), 6cde2907d (6.5), 434ea4401 (dev), e3bfc1a2e (dev)
-
Foundation Sprint 64, Foundation Sprint 65, Foundation Sprint 66, Foundation Sprint 67, Foundation Sprint 68, Foundation Sprint 69, Foundation Sprint 70, Foundation Sprint 71, Foundation Sprint 72, Foundation Sprint 73, Foundation Sprint 74, Foundation Sprint 75, Foundation Sprint 76
Description
Let's be honest: the change from int to qsizetype sizes in Qt 6.0 was more than rushed. Half the API and a good chunk of implementation code is still using int when it should be using qsizetype, and we have been papering over this issue by making qMin() allow mixed-type arguments and, apparently, by removing the annoying MSVC warnings that, in Qt 5, so nicely pin-pointed all these implicit conversions as hard errors.
There were several real bugs in e.g. the QBuffer code corresponding to int/qsizetype, so there's probably more.
Acceptance criterium: every int has been inspected and, if needed, ported to qsizetype. Unfortunately, relying on compiler warnings isn't enough, as explicit casts won't raise warnings, but need to be ported nonetheless.
Attachments
Issue Links
- is blocked by
-
QTBUG-105950 Cannot change the type of member used in the Q_PROPERTY without breaking compatibility
- Reported
Gerrit Reviews
For Gerrit Dashboard: QTBUG-103530 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
428873,29 | Migration from int to qsizetype of QAbstractAnimation | dev | qt/qtbase | Status: NEW | 0 | 0 |
430006,26 | Migration from int to qsizetype of corelib/animation | dev | qt/qtbase | Status: NEW | 0 | 0 |
430607,29 | Use range-based for loops and qint64 in corelib/animation | dev | qt/qtbase | Status: NEW | 0 | 0 |
428904,8 | Adapt QQmlAnimationTimer to change in base-class virtual method | dev | qt/qtdeclarative | Status: ABANDONED | +2 | 0 |
429370,30 | Migration from int to qsizetype of QAnimationGroup | dev | qt/qtbase | Status: MERGED | +2 | 0 |
457742,2 | Migration from int to qsizetype of QAnimationGroup | 6.5 | qt/qtbase | Status: MERGED | +2 | 0 |
567529,3 | Prepare for Q{AbstractAnimation,Unified}Timer::runningAnimationCount() return value change | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
567558,2 | Q{AbstractAnimation,Unified}Timer: Port runningAnimationCount() to qsizetype | dev | qt/qtbase | Status: MERGED | +2 | 0 |