Loading...

XML

Word

Printable

Type: Task
Resolution: Done
Priority: P2: Important
Fix Version/s: 6.2.6, 6.4.0 RC1, 6.5.0 Beta1
Affects Version/s: None
Component/s: Core: QString and Unicode
Labels:
None

Epic Link:
qsizetype
Story Points:
21
Commits:
334c27dad1 (qt/qtbase/dev) 334c27dad1 (qt/tqtc-qtbase/dev) e8e91ef35c (qt/qtbase/6.4) e8e91ef35c (qt/tqtc-qtbase/6.4) e8e91ef35c (qt/tqtc-qtbase/6.4.0) 5018ab86be (qt/tqtc-qtbase/6.2) d41c841e07 (qt/qtbase/6.3) d41c841e07 (qt/tqtc-qtbase/6.3)
Sprint:
Foundation Sprint 61, Foundation Sprint 62, Foundation Sprint 63, Foundation Sprint 64, Foundation Sprint 65

Let's be honest: the change from int to qsizetype sizes in Qt 6.0 was more than rushed. Half the API and a good chunk of implementation code is still using int when it should be using qsizetype, and we have been papering over this issue by making qMin() allow mixed-type arguments and, apparently, by removing the annoying MSVC warnings that, in Qt 5, so nicely pin-pointed all these implicit conversions as hard errors.

There were several real bugs in e.g. the QBuffer code corresponding to int/qsizetype, so there's probably more.

Acceptance criterium: every int has been inspected and, if needed, ported to qsizetype. Unfortunately, relying on compiler warnings isn't enough, as explicit casts won't raise warnings, but need to be ported nonetheless.

is cloned by

QTBUG-105471 Finish migration to qsizetype [qtbase/src/widgets/graphicsview]

Open

relates to

QTBUG-105717 REG [5.15 -> 6.x] QByteArray::replace(0, size(), ptr, n) became ambiguous on 64-bit platforms

Closed

resulted in

QTBUG-105038 QCollator is limited to ≤ 2Gi characters

Open

QTBUG-105034 QDataStream cannot serialize containers > 2Gi elements

Closed

QTBUG-105544 qunicodetools.cpp: libthai's th_brk is not thread-safe [2/2]: new API

Closed

QTBUG-106360 qunicodetools.cpp: libthai's th_brk is not thread-safe [1/2]: try fix using old API

Closed

QTBUG-105103 QString::localeAwareCompare() reports wrong result for more than 2Gi character long strings

Open

QTBUG-105541 libthai th_brk is limited to ≤ 2Gi characters

Open

QTBUG-138860 qvsnprintf() incorrectly reports success when it should report EOVERFLOW

Closed

QTBUG-104972 qUncompress(qCompress()) round-trip fails for data > 2GiB

Closed

QTBUG-104985 QByteArray::fromBase64Encoding(toBase64()) round-trip fails for data > 2GiB

Closed

QTBUG-105027 QByteArray::count(ch) reports wrong result for more than 2Gi occurrences

Closed

QTBUG-105047 QLocale::createSeparatedList() is reports wrong result for lists with more than 2Gi elements

Closed

QTBUG-105100 Review QLocale/Win for INT_MAX issues.

Closed

QTBUG-105101 QRegularExpression is limited to ≤ 2Gi characters

Closed

QTBUG-105104 QString::toHtmlEscaped() fails for more than 2Gi character long strings

Closed

QTBUG-105105 QStringConverter/Win is not 64-bit-clean

Closed

QTBUG-105543 Several data races in qunicodetools.cpp thai support initalization

Closed

(13 resulted in)

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-103531
#	Subject	Branch	Project	Status	CR	V
422283,3	QCollator: port compare(ptr, n, ptr, n) to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
422343,3	QLocale/Win: fix truncation bug in winIso639LangName()	dev	qt/qtbase	Status: MERGED	+2	0
422378,2	Port qt_repeatCount() to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
422815,3	Port qt_doubleToAscii to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
422828,2	QLocale/Win: fix truncation bug in winIso639LangName()	6.4	qt/qtbase	Status: MERGED	+2	0
422829,2	QCollator: port compare(ptr, n, ptr, n) to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
422830,2	QLocale/Win: fix truncation bug in winIso639LangName()	6.3	qt/qtbase	Status: MERGED	+2	0
422860,2	Port qt_repeatCount() to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
422861,2	Port qt_repeatCount() to qsizetype	6.3	qt/qtbase	Status: MERGED	+2	0
422886,4	QLocale/Win: fix truncation bug in winIso639LangName()	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
422890,3	Port qt_repeatCount() to qsizetype	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
422900,4	QLocale: port locale_data indexing to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
422903,3	Port QStringIterator to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
422992,3	QLocale: port to qsizetype [1/N]: indexed to ranged loops	dev	qt/qtbase	Status: MERGED	+2	0
422993,4	QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial)	dev	qt/qtbase	Status: MERGED	+2	0
422994,2	Fix QString::toLatin1() for strings > 16Gi characters on ARM64	dev	qt/qtbase	Status: MERGED	+2	0
422995,2	Fix QString::vasprintf for strings > 2GiB	dev	qt/qtbase	Status: MERGED	+2	0
422996,2	Fix QString::arg() for format strings > 2Gi characters	dev	qt/qtbase	Status: MERGED	+2	0
422997,2	Fix QString::arg() for format strings with a huge amount of placeholders	dev	qt/qtbase	Status: MERGED	+2	0
422998,4	Statically assert that the __mips_dsp code is only active on 32-bit	dev	qt/qtbase	Status: MERGED	+2	0
422999,2	Fix stringish::simplified() for strings > 2Gi characters	dev	qt/qtbase	Status: MERGED	+2	0
423404,2	Port QUtf8BaseTraits to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
423683,2	Fix QString::toLatin1() for strings > 16Gi characters on ARM64	6.4	qt/qtbase	Status: MERGED	+2	0
423684,2	Fix QString::toLatin1() for strings > 16Gi characters on ARM64	6.3	qt/qtbase	Status: MERGED	+2	0
423685,2	Fix QString::vasprintf for strings > 2GiB	6.4	qt/qtbase	Status: MERGED	+2	0
423686,2	Fix QString::vasprintf for strings > 2GiB	6.3	qt/qtbase	Status: MERGED	+2	0
423687,2	QLocale: port to qsizetype [1/N]: indexed to ranged loops	6.4	qt/qtbase	Status: MERGED	+2	0
423688,3	QLocale: port to qsizetype [1/N]: indexed to ranged loops	6.3	qt/qtbase	Status: MERGED	+2	0
423689,2	Fix QString::arg() for format strings with a huge amount of placeholders	6.3	qt/qtbase	Status: MERGED	+2	0
423690,2	Fix QString::arg() for format strings with a huge amount of placeholders	6.4	qt/qtbase	Status: MERGED	+2	0
423693,2	Port qt_doubleToAscii to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
423694,2	Port qt_doubleToAscii to qsizetype	6.3	qt/qtbase	Status: MERGED	+2	0
423695,2	Port QUtf8BaseTraits to qsizetype	6.3	qt/qtbase	Status: MERGED	+2	0
423696,2	Port QUtf8BaseTraits to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
423697,2	Port QStringIterator to qsizetype	6.3	qt/qtbase	Status: MERGED	+2	0
423698,2	Port QStringIterator to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
423699,2	Fix stringish::simplified() for strings > 2Gi characters	6.3	qt/qtbase	Status: MERGED	+2	0
423700,2	Fix stringish::simplified() for strings > 2Gi characters	6.4	qt/qtbase	Status: MERGED	+2	0
423703,2	Fix QString::toLatin1() for strings > 16Gi characters on ARM64	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
423704,2	Fix QString::vasprintf for strings > 2GiB	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
423707,2	Port QUtf8BaseTraits to qsizetype	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
423708,3	Port QStringIterator to qsizetype	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
423709,2	Fix stringish::simplified() for strings > 2Gi characters	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
424976,2	Statically assert that the __mips_dsp code is only active on 32-bit	6.4	qt/qtbase	Status: MERGED	+2	0
424977,2	Statically assert that the __mips_dsp code is only active on 32-bit	6.3	qt/qtbase	Status: MERGED	+2	0
424978,2	Fix QString::arg() for format strings > 2Gi characters	6.4	qt/qtbase	Status: MERGED	+2	0
424979,2	Fix QString::arg() for format strings > 2Gi characters	6.3	qt/qtbase	Status: MERGED	+2	0
424991,2	Statically assert that the __mips_dsp code is only active on 32-bit	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
424992,2	Statically assert that the __mips_dsp code is only active on 32-bit	tqtc/lts-5.15	qt/tqtc-qtbase	Status: MERGED	+2	0
424993,2	Fix QString::arg() for format strings > 2Gi characters	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426053,3	QUnicodeTools: fix types used around th_next_cell	dev	qt/qtbase	Status: MERGED	+2	0
426167,2	QUnicodeTools: fix types used around th_brk()	dev	qt/qtbase	Status: MERGED	+2	0
426195,2	QUnicodeTools: fix truncation in debug statements	dev	qt/qtbase	Status: MERGED	+2	0
426226,2	[docs] Fix return value of QStringIterator::next()	dev	qt/qtbase	Status: MERGED	+2	0
426231,2	QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers	dev	qt/qtbase	Status: MERGED	+2	0
426245,2	Finish porting cross-platform parts of QStringConverter to qsizetype/size_t	dev	qt/qtbase	Status: MERGED	+2	0
426254,2	QTextBoundaryFinder: fix a flawed buffer size calculation	dev	qt/qtbase	Status: MERGED	+2	0
426256,2	Port qt_readEscapedFormatString() to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
426257,2	QLocale: port findTag to std::string_view	dev	qt/qtbase	Status: MERGED	+2	0
426305,2	QUnicodeTools: fix types used around th_next_cell	6.4	qt/qtbase	Status: MERGED	+2	0
426306,2	QUnicodeTools: fix types used around th_next_cell	6.3	qt/qtbase	Status: MERGED	+2	0
426309,2	[docs] Fix return value of QStringIterator::next()	6.4	qt/qtbase	Status: MERGED	+2	0
426310,2	[docs] Fix return value of QStringIterator::next()	6.3	qt/qtbase	Status: MERGED	+2	0
426311,2	QUnicodeTools: fix truncation in debug statements	6.3	qt/qtbase	Status: MERGED	+2	0
426312,2	QUnicodeTools: fix truncation in debug statements	6.4	qt/qtbase	Status: MERGED	+2	0
426313,2	QUnicodeTools: fix types used around th_brk()	6.3	qt/qtbase	Status: MERGED	+2	0
426314,2	QUnicodeTools: fix types used around th_brk()	6.4	qt/qtbase	Status: MERGED	+2	0
426316,2	QUnicodeTools: fix types used around th_next_cell	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426318,3	[docs] Fix return value of QStringIterator::next()	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426319,2	QUnicodeTools: fix truncation in debug statements	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426320,2	QUnicodeTools: fix types used around th_brk()	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426327,2	QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers	6.4	qt/qtbase	Status: MERGED	+2	0
426328,2	QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers	6.3	qt/qtbase	Status: MERGED	+2	0
426336,2	QTextBoundaryFinder: fix a flawed buffer size calculation	6.3	qt/qtbase	Status: MERGED	+2	0
426377,2	QString: finish migration to qsizetype	dev	qt/qtbase	Status: MERGED	+2	0
426378,2	[docs] Fix ints that should be qsizetype [src/corelib/text]	dev	qt/qtbase	Status: MERGED	+2	0
426421,3	QTextBoundaryFinder: fix a flawed buffer size calculation	6.4	qt/qtbase	Status: MERGED	+2	0
426422,2	Port qt_readEscapedFormatString() to qsizetype	6.3	qt/qtbase	Status: MERGED	+2	0
426423,2	Port qt_readEscapedFormatString() to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
426424,2	QLocale: port findTag to std::string_view	6.3	qt/qtbase	Status: MERGED	+2	0
426425,2	QLocale: port findTag to std::string_view	6.4	qt/qtbase	Status: MERGED	+2	0
426426,2	Finish porting cross-platform parts of QStringConverter to qsizetype/size_t	6.4	qt/qtbase	Status: MERGED	+2	0
426429,3	Port qt_readEscapedFormatString() to qsizetype	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
426484,2	QChar: replace uint with char32_t in the implementation	dev	qt/qtbase	Status: MERGED	+2	0
426509,2	QString: finish migration to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
426538,2	QChar: replace uint with char32_t in the implementation	6.4	qt/qtbase	Status: MERGED	+2	0
426539,2	QLocale: port locale_data indexing to qsizetype	6.4	qt/qtbase	Status: MERGED	+2	0
427160,1	[docs] Q*StringView returns sizetype these days	dev	qt/qtbase	Status: ABANDONED	0	0
430065,3	[docs] Fix ints that should be qsizetype [src/corelib/text]	6.3	qt/qtbase	Status: MERGED	+2	0
430066,2	[docs] Fix ints that should be qsizetype [src/corelib/text]	6.4	qt/qtbase	Status: MERGED	+2	0
430067,2	QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial)	6.4	qt/qtbase	Status: MERGED	+2	0
430068,2	QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial)	6.3	qt/qtbase	Status: MERGED	+2	0
430074,3	[docs] Fix ints that should be qsizetype [src/corelib/text]	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0