Loading...

XML

Word

Printable

Type: Task
Resolution: Done
Priority: P2: Important
Fix Version/s: 6.2.6, 6.4.0 RC1, 6.5.0 Beta1
Affects Version/s: None
Component/s: Core: QString and Unicode
Labels:
None

Epic Link:
qsizetype
Story Points:
21
Commits:
334c27dad1 (qt/qtbase/dev) 334c27dad1 (qt/tqtc-qtbase/dev) e8e91ef35c (qt/qtbase/6.4) e8e91ef35c (qt/tqtc-qtbase/6.4) e8e91ef35c (qt/tqtc-qtbase/6.4.0) 5018ab86be (qt/tqtc-qtbase/6.2) d41c841e07 (qt/qtbase/6.3) d41c841e07 (qt/tqtc-qtbase/6.3)
Sprint:
Foundation Sprint 61, Foundation Sprint 62, Foundation Sprint 63, Foundation Sprint 64, Foundation Sprint 65

Let's be honest: the change from int to qsizetype sizes in Qt 6.0 was more than rushed. Half the API and a good chunk of implementation code is still using int when it should be using qsizetype, and we have been papering over this issue by making qMin() allow mixed-type arguments and, apparently, by removing the annoying MSVC warnings that, in Qt 5, so nicely pin-pointed all these implicit conversions as hard errors.

There were several real bugs in e.g. the QBuffer code corresponding to int/qsizetype, so there's probably more.

Acceptance criterium: every int has been inspected and, if needed, ported to qsizetype. Unfortunately, relying on compiler warnings isn't enough, as explicit casts won't raise warnings, but need to be ported nonetheless.

is cloned by

QTBUG-105471 Finish migration to qsizetype [qtbase/src/widgets/graphicsview]

Open

relates to

QTBUG-105717 REG [5.15 -> 6.x] QByteArray::replace(0, size(), ptr, n) became ambiguous on 64-bit platforms

Closed

resulted in

QTBUG-105038 QCollator is limited to ≤ 2Gi characters

Open

QTBUG-105034 QDataStream cannot serialize containers > 2Gi elements

Closed

QTBUG-105544 qunicodetools.cpp: libthai's th_brk is not thread-safe [2/2]: new API

Closed

QTBUG-106360 qunicodetools.cpp: libthai's th_brk is not thread-safe [1/2]: try fix using old API

Closed

QTBUG-105103 QString::localeAwareCompare() reports wrong result for more than 2Gi character long strings

Open

QTBUG-105541 libthai th_brk is limited to ≤ 2Gi characters

Open

QTBUG-138860 qvsnprintf() incorrectly reports success when it should report EOVERFLOW

Closed

QTBUG-104972 qUncompress(qCompress()) round-trip fails for data > 2GiB

Closed

QTBUG-104985 QByteArray::fromBase64Encoding(toBase64()) round-trip fails for data > 2GiB

Closed

QTBUG-105027 QByteArray::count(ch) reports wrong result for more than 2Gi occurrences

Closed

QTBUG-105047 QLocale::createSeparatedList() is reports wrong result for lists with more than 2Gi elements

Closed

QTBUG-105100 Review QLocale/Win for INT_MAX issues.

Closed

QTBUG-105101 QRegularExpression is limited to ≤ 2Gi characters

Closed

QTBUG-105104 QString::toHtmlEscaped() fails for more than 2Gi character long strings

Closed

QTBUG-105105 QStringConverter/Win is not 64-bit-clean

Closed

QTBUG-105543 Several data races in qunicodetools.cpp thai support initalization

Closed

(13 resulted in)

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Assignee:: Marc Mutz

Reporter:: Marc Mutz

PM Owner:: Vladimir Minenko

RnD Owner:: Alex Blasche

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 17 May '22 08:10

Updated:: 01 Aug '25 09:52

Resolved:: 01 Sep '22 13:52

There are no open Gerrit changes

Show There are 93 closed Gerrit changes

Hide There are 93 closed Gerrit changes

QCollator: port compare(ptr, n, ptr, n) to qsizetype: Gerrit Review:

QLocale/Win: fix truncation bug in winIso639LangName(): Gerrit Review:

Port qt_repeatCount() to qsizetype: Gerrit Review:

Port qt_doubleToAscii to qsizetype: Gerrit Review:

QLocale/Win: fix truncation bug in winIso639LangName(): Gerrit Review:

QCollator: port compare(ptr, n, ptr, n) to qsizetype: Gerrit Review:

QLocale/Win: fix truncation bug in winIso639LangName(): Gerrit Review:

Port qt_repeatCount() to qsizetype: Gerrit Review:

Port qt_repeatCount() to qsizetype: Gerrit Review:

QLocale/Win: fix truncation bug in winIso639LangName(): Gerrit Review:

Port qt_repeatCount() to qsizetype: Gerrit Review:

QLocale: port locale_data indexing to qsizetype: Gerrit Review:

Port QStringIterator to qsizetype: Gerrit Review:

QLocale: port to qsizetype [1/N]: indexed to ranged loops: Gerrit Review:

QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial): Gerrit Review:

Fix QString::toLatin1() for strings > 16Gi characters on ARM64: Gerrit Review:

Fix QString::vasprintf for strings > 2GiB: Gerrit Review:

Fix QString::arg() for format strings > 2Gi characters: Gerrit Review:

Fix QString::arg() for format strings with a huge amount of placeholders: Gerrit Review:

Statically assert that the __mips_dsp code is only active on 32-bit: Gerrit Review:

Fix stringish::simplified() for strings > 2Gi characters: Gerrit Review:

Port QUtf8BaseTraits to qsizetype: Gerrit Review:

Fix QString::toLatin1() for strings > 16Gi characters on ARM64: Gerrit Review:

Fix QString::toLatin1() for strings > 16Gi characters on ARM64: Gerrit Review:

Fix QString::vasprintf for strings > 2GiB: Gerrit Review:

Fix QString::vasprintf for strings > 2GiB: Gerrit Review:

QLocale: port to qsizetype [1/N]: indexed to ranged loops: Gerrit Review:

QLocale: port to qsizetype [1/N]: indexed to ranged loops: Gerrit Review:

Fix QString::arg() for format strings with a huge amount of placeholders: Gerrit Review:

Fix QString::arg() for format strings with a huge amount of placeholders: Gerrit Review:

Port qt_doubleToAscii to qsizetype: Gerrit Review:

Port qt_doubleToAscii to qsizetype: Gerrit Review:

Port QUtf8BaseTraits to qsizetype: Gerrit Review:

Port QUtf8BaseTraits to qsizetype: Gerrit Review:

Port QStringIterator to qsizetype: Gerrit Review:

Port QStringIterator to qsizetype: Gerrit Review:

Fix stringish::simplified() for strings > 2Gi characters: Gerrit Review:

Fix stringish::simplified() for strings > 2Gi characters: Gerrit Review:

Fix QString::toLatin1() for strings > 16Gi characters on ARM64: Gerrit Review:

Fix QString::vasprintf for strings > 2GiB: Gerrit Review:

Port QUtf8BaseTraits to qsizetype: Gerrit Review:

Port QStringIterator to qsizetype: Gerrit Review:

Fix stringish::simplified() for strings > 2Gi characters: Gerrit Review:

Statically assert that the __mips_dsp code is only active on 32-bit: Gerrit Review:

Statically assert that the __mips_dsp code is only active on 32-bit: Gerrit Review:

Fix QString::arg() for format strings > 2Gi characters: Gerrit Review:

Fix QString::arg() for format strings > 2Gi characters: Gerrit Review:

Statically assert that the __mips_dsp code is only active on 32-bit: Gerrit Review:

Statically assert that the __mips_dsp code is only active on 32-bit: Gerrit Review:

Fix QString::arg() for format strings > 2Gi characters: Gerrit Review:

QUnicodeTools: fix types used around th_next_cell: Gerrit Review:

QUnicodeTools: fix types used around th_brk(): Gerrit Review:

QUnicodeTools: fix truncation in debug statements: Gerrit Review:

[docs] Fix return value of QStringIterator::next(): Gerrit Review:

QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers: Gerrit Review:

Finish porting cross-platform parts of QStringConverter to qsizetype/size_t: Gerrit Review:

QTextBoundaryFinder: fix a flawed buffer size calculation: Gerrit Review:

Port qt_readEscapedFormatString() to qsizetype: Gerrit Review:

QLocale: port findTag to std::string_view: Gerrit Review:

QUnicodeTools: fix types used around th_next_cell: Gerrit Review:

QUnicodeTools: fix types used around th_next_cell: Gerrit Review:

[docs] Fix return value of QStringIterator::next(): Gerrit Review:

[docs] Fix return value of QStringIterator::next(): Gerrit Review:

QUnicodeTools: fix truncation in debug statements: Gerrit Review:

QUnicodeTools: fix truncation in debug statements: Gerrit Review:

QUnicodeTools: fix types used around th_brk(): Gerrit Review:

QUnicodeTools: fix types used around th_brk(): Gerrit Review:

QUnicodeTools: fix types used around th_next_cell: Gerrit Review:

[docs] Fix return value of QStringIterator::next(): Gerrit Review:

QUnicodeTools: fix truncation in debug statements: Gerrit Review:

QUnicodeTools: fix types used around th_brk(): Gerrit Review:

QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers: Gerrit Review:

QString: fix arg() for >2Gi repeated lowest-escape-sequence-numbers: Gerrit Review:

QTextBoundaryFinder: fix a flawed buffer size calculation: Gerrit Review:

QString: finish migration to qsizetype: Gerrit Review:

[docs] Fix ints that should be qsizetype [src/corelib/text]: Gerrit Review:

QTextBoundaryFinder: fix a flawed buffer size calculation: Gerrit Review:

Port qt_readEscapedFormatString() to qsizetype: Gerrit Review:

Port qt_readEscapedFormatString() to qsizetype: Gerrit Review:

QLocale: port findTag to std::string_view: Gerrit Review:

QLocale: port findTag to std::string_view: Gerrit Review:

Finish porting cross-platform parts of QStringConverter to qsizetype/size_t: Gerrit Review:

Port qt_readEscapedFormatString() to qsizetype: Gerrit Review:

QChar: replace uint with char32_t in the implementation: Gerrit Review:

QString: finish migration to qsizetype: Gerrit Review:

QChar: replace uint with char32_t in the implementation: Gerrit Review:

QLocale: port locale_data indexing to qsizetype: Gerrit Review:

[docs] Q*StringView returns sizetype these days: Gerrit Review:

[docs] Fix ints that should be qsizetype [src/corelib/text]: Gerrit Review:

[docs] Fix ints that should be qsizetype [src/corelib/text]: Gerrit Review:

QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial): Gerrit Review:

QLocale: port to qsizetype [2/N]: remainder (qlocale_win.cpp partial): Gerrit Review:

[docs] Fix ints that should be qsizetype [src/corelib/text]: Gerrit Review: