Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
5
-
edddb33b69 (qt/qtpositioning/dev) edddb33b69 (qt/tqtc-qtpositioning/dev)
-
Foundation Sprint 61, Foundation Sprint 62, Foundation Sprint 63, Foundation Sprint 64, Foundation Sprint 65, Foundation Sprint 66
Description
Let's be honest: the change from int to qsizetype sizes in Qt 6.0 was more than rushed. Half the API and a good chunk of implementation code is still using int when it should be using qsizetype, and we have been papering over this issue by making qMin() allow mixed-type arguments and, apparently, by removing the annoying MSVC warnings that, in Qt 5, so nicely pin-pointed all these implicit conversions as hard errors.
There were several real bugs in e.g. the QBuffer code corresponding to int/qsizetype, so there's probably more.
Acceptance criterium: every int has been inspected and, if needed, ported to qsizetype. Unfortunately, relying on compiler warnings isn't enough, as explicit casts won't raise warnings, but need to be ported nonetheless.
Attachments
| For Gerrit Dashboard: QTBUG-103552 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 422384,26 | Introduce new interfaces using QByteArrayView | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424358,5 | Replace int with qsizetype, count() with size() | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424359,17 | Replace const char *pointer and size with QByteArrayView | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424878,7 | Replace indexed for loops with ranged for loops | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424879,10 | Use removeIf to remove child pipes | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424880,4 | Remove sorting from QGeoPositionInfo::debugStreaming | dev | qt/qtpositioning | Status: ABANDONED | -1 | 0 |
| 424881,7 | Use std::min_element to select the best QGeoPositionInfo | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 424882,9 | Use isEmpty() to check for empty container | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425259,13 | Delegate parsing of milliseconds to QTime::fromString() | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425519,2 | Replace int with qsizetype, count() with size() | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425520,2 | Replace int with qsizetype, count() with size() | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425529,3 | Replace int with qsizetype, count() with size() | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 425563,2 | Replace indexed for loops with ranged for loops | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425564,2 | Replace indexed for loops with ranged for loops | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425569,2 | Replace indexed for loops with ranged for loops | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 425695,2 | Use removeIf to remove child pipes | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425696,2 | Use removeIf to remove child pipes | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 425732,2 | Use removeIf to remove child pipes | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 425738,5 | Use std::remove_if + QVector::erase to remove child pipes | tqtc/lts-5.15 | qt/tqtc-qtlocation | Status: MERGED | +2 | 0 |
| 426260,3 | Fix undefined behavior in qlocationutils_readGsa() | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 426261,3 | Use toInt() to convert QByteArray into int | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 426298,6 | Use isEmpty() to check for empty container | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 426299,3 | Use isEmpty() to check for empty container | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 426300,3 | Use isEmpty() to check for empty container | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 427073,6 | Make hasValidNmeaChecksum more robust against overflow | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 427285,2 | Fix undefined behavior in qlocationutils_readGsa() | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 427286,2 | Fix undefined behavior in qlocationutils_readGsa() | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 427319,2 | Fix undefined behavior in qlocationutils_readGsa() | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 427506,2 | Use toInt() to convert QByteArray into int | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 427507,4 | Use toInt() to convert QByteArray into int | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 427509,4 | Use toInt() to convert QByteArray into int | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 427557,4 | Fix undefined behavior in qlocationutils_readGsa() | tqtc/lts-5.15 | qt/tqtc-qtlocation | Status: MERGED | +2 | 0 |
| 429145,2 | Use a different overload of QIODevice::readLine | dev | qt/qtpositioning | Status: ABANDONED | -1 | 0 |
| 431245,4 | Make hasValidNmeaChecksum more robust against overflow | 6.4 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 431246,4 | Make hasValidNmeaChecksum more robust against overflow | 6.3 | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 431251,3 | Make hasValidNmeaChecksum more robust against overflow | tqtc/lts-6.2 | qt/tqtc-qtpositioning | Status: MERGED | +2 | 0 |
| 431806,2 | Fix name of test case in tst_nmeasatelliteinfosource.cpp | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |
| 431819,8 | Check the result of readline | dev | qt/qtpositioning | Status: MERGED | +2 | 0 |