Loading...

XML

Word

Printable

Details

Type: Task
Resolution: Fixed
Priority: P2: Important
Fix Version/s: 6.6.0 Beta2, 6.6, 6.7.0 FF
Affects Version/s: None
Component/s: QML: Declarative and Javascript Engine, Quick: Core Declarative QML
Labels:
None

Epic Link:
C++20 attributes @ Qt
Story Points:
5
Commits:
e79e850c2 (dev), 018d26955 (dev), c33c69fc2 (6.6), 519b50d17 (6.6), cb5577763 (dev), ef9fe5d61 (dev), 1ee1a2f5b (dev), bfec2150e (dev), b12abcf09 (6.6), 38075f9b2 (6.6), ad6470ef8 (6.6), ecf3cbc1b (6.6), a7603a39f (6.5)
Sprint:
Foundation Sprint 85

Description

Depending on the outcome of ~~QTBUG-104161~~, add either [[nodiscard]] directly, or the wrapper macro to those ctors that ~~QTBUG-104167~~ defines as targets.

Attachments

Issue Links

is blocked by

QTBUG-104161 [spike] Find out whether all supported compilers support [[nodiscard]] on ctor, add macro if not

Closed

QTBUG-104167 [spike] Create a policy for [[nodiscard]] on ctors

Closed

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-104168
#	Subject	Branch	Project	Status	CR	V
487539,3	QQmlRefPointer: mark ctors as [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487540,2	QBiPointer: mark ctors as [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487584,2	QQmlRefPointer: mark ctors as [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0
487585,2	QBiPointer: mark ctors as [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0
487632,2	QDeferred(Shared\|Weak)Pointer: mark certain operation [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487633,2	QDeferred(Shared\|Weak)Pointer: mark constructors [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487635,2	QQmlGuard: mark constructors [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487636,3	Div. smart pointer/raii classes: mark ctors [[nodiscard]]	dev	qt/qtdeclarative	Status: MERGED	+2	0
487839,2	QQmlGuard: mark constructors [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0
487841,2	QDeferred(Shared\|Weak)Pointer: mark certain operation [[nodiscard]]	6.5	qt/qtdeclarative	Status: MERGED	+2	0
487842,2	QDeferred(Shared\|Weak)Pointer: mark certain operation [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0
487843,2	Div. smart pointer/raii classes: mark ctors [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0
487844,3	QDeferred(Shared\|Weak)Pointer: mark constructors [[nodiscard]]	6.6	qt/qtdeclarative	Status: MERGED	+2	0