Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104541

Merge Finddouble-conversion.cmake contents into FindWrapDoubleConversion.cmake

    XMLWordPrintable

    Details

    • Commits:
      a310319a04 (qt/qtbase/dev) a310319a04 (qt/tqtc-qtbase/dev) 7fe7441075 (qt/qtbase/6.3) 7fe7441075 (qt/tqtc-qtbase/6.3) 0284168bc3 (qt/qtbase/6.4) 0284168bc3 (qt/tqtc-qtbase/6.4) 1402ebd7ed (qt/tqtc-qtbase/6.2)

      Description

      Qt ships 2 Find modules for the double conversion library:
      FindWrapDoubleConversion.cmake
      Finddouble-conversion.cmake

      This is troublesome if somebody who builds Qt wants to user their own Finddouble-conversion.cmake file, because the Qt one is always preferred.

      One particular use case of this is building Qt with 3rd party dependencies provided by Conan, where Conan would generate its own Finddouble-conversion.cmake file.

      To allow others to provide their own file, we should instead merge the contents of Finddouble-conversion.cmake into FindWrapDoubleConversion.cmake and only use that code if the 3rd party one could not be found.

      This is a slight behavior change, and might cause some issues in case if pre-existing Finddouble-conversion files in the wild are broken (we've had multiple issues we had to work around with harfbuzz config files for example).

      At the same time, for consistency, we could rename the file to FindWrapSystemDoubleConversion.cmake

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              alexandru.croitor Alexandru Croitor
              Reporter:
              alexandru.croitor Alexandru Croitor
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes