Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104915

void QObject::addChild(std::unique_ptr<QObject>)

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: Not Evaluated Not Evaluated
    • None
    • None
    • Core: Object Model
    • PM Spotted

      The `child->setParent(parent)` behavior is an implicit ownership transfer. Adding `void QObject::addChild(std::unique_ptr<QObject> child) { if (child)

      { child->setParent(this); child.release(); }

      }` would make this transfer explicit and much easier to be exception-safe. 

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            vhilshei Volker Hilsheimer
            BenFrantzDale Benjamin FrantzDale
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes