Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
6.3.0
-
709ca8212e (qt/qtbase/dev) 709ca8212e (qt/tqtc-qtbase/dev) ff37a211da (qt/qtbase/6.3) ff37a211da (qt/tqtc-qtbase/6.3) 69676296b2 (qt/qtbase/6.4) 69676296b2 (qt/tqtc-qtbase/6.4) ff5c351cab (qt/tqtc-qtbase/6.2), b47e0cef8 (tqtc/lts-5.15)
Description
The first argument of QFileDialog::getOpenFileContent is nameFilter – in the Q_OS_WASM block, this is unused (with a comment about Qt and Web name filter string formats), but in the else block which is to be used on non-WASM platforms, it is being passed to a newly created QFileDialog via `selectNameFilter(nameFilter)` where no filters have yet to be set.
The fix is simple, which should simply be to swap in `setNameFilter(nameFilter);` instead at line 2337.
(Bonus points if nameFilter can be honored in the WASM section of the function!)
Attachments
Issue Links
- relates to
-
-
- Closed
-
| For Gerrit Dashboard: QTBUG-104948 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 426495,3 | Fix ignored name filter in QFileDialog::getOpenFileContent() | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 426784,2 | Fix ignored name filter in QFileDialog::getOpenFileContent() | 6.4 | qt/qtbase | Status: MERGED | +2 | 0 |
| 426785,2 | Fix ignored name filter in QFileDialog::getOpenFileContent() | 6.3 | qt/qtbase | Status: MERGED | +2 | 0 |
| 426788,2 | Fix ignored name filter in QFileDialog::getOpenFileContent() | tqtc/lts-5.15 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 426789,2 | Fix ignored name filter in QFileDialog::getOpenFileContent() | tqtc/lts-6.2 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 483557,1 | Fix ignored name filter in QFileDialog::getOpenFileContent() | tqtc/lts-5.15-vxworks | qt/tqtc-qtbase | Status: ABANDONED | 0 | 0 |