Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-105165

Include IMPORTED_TARGETS in _qt_internal_collect_buildsystem_shared_libraries

    XMLWordPrintable

Details

    • Android
    • 6abaff810a (qt/qtbase/dev) 6abaff810a (qt/tqtc-qtbase/dev)

    Description

      _qt_internal_collect_buildsystem_shared_libraries seems to pick up BUILDSYSTEM_TARGETS with:

      get_directory_property(buildsystem_targets DIRECTORY ${subdir} BUILDSYSTEM_TARGETS)

      https://cmake.org/cmake/help/latest/prop_dir/BUILDSYSTEM_TARGETS.html

      However, according to the docs that doesn't include binaries which are added with IMPORTED add_library.

      Suggestion:

      Make the function similarly pick up IMPORTED_TARGETS as well. Example:

      get_directory_property(buildsystem_imported_targets DIRECTORY ${subdir} IMPORTED_TARGETS)
      

      Why:

      The libraries are anyway needed when deploying and it'd simplify importing libraries in complex project structures.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              alexandru.croitor Alexandru Croitor
              miikapernu Miika Pernu
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes