Details
-
Bug
-
Resolution: Done
-
P2: Important
-
6.2.5
-
None
-
Linux/Other display system
-
a29af6656f (qt/qtbase/dev) a29af6656f (qt/tqtc-qtbase/dev) c1b63ba124 (qt/tqtc-qtbase/6.2) 25ba921d50 (qt/qtbase/6.4) 25ba921d50 (qt/tqtc-qtbase/6.4) d448a0a611 (qt/qtbase/6.3) d448a0a611 (qt/tqtc-qtbase/6.3)
Description
Using -system-doubleconversion fails the build because the include dir is set to
path-to-double-conversion/include/double-conversion
But qdoublescanprint_p.h looks for :
# include <double-conversion/double-conversion.h>
In file included from /foobar/source-lts/qtbase/src/corelib/text/qlocale_tools.cpp:42: /foobar/source-lts/qtbase/src/corelib/text/qdoublescanprint_p.h:151:14: fatal error: double-conversion/double-conversion.h: No such file or directory 151 | # include <double-conversion/double-conversion.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [qtbase/src/corelib/CMakeFiles/Core.dir/build.make:1733: qtbase/src/corelib/CMakeFiles/Core.dir/text/qlocale_tools.cpp.o] Error 1
https://github.com/qt/qtbase/blob/dev/cmake/FindWrapSystemDoubleConversion.cmake#L32-L37
This should be changed :
find_path(DOUBLE_CONVERSION_INCLUDE_DIR
NAMES
double-conversion.h
PATH_SUFFIXES
double-conversion
)
To following:
find_path(DOUBLE_CONVERSION_INCLUDE_DIR
NAMES
double-conversion/double-conversion.h
)