Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-106184

QString: don't detach in replace()

    XMLWordPrintable

Details

    • Task
    • Status: Open
    • P2: Important
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      After we've detected that we need to change the container in replace(), don't detach(). Instead, check if we're shared. If we're not shared, and the replacee is larger than the replacer, do the change in-place. Otherwise, make a new container, copy the subset that forms the final result over, then assign the new container to *this.

      See epic for more details.

      Acceptance criteria: The following member functions no longer detach:

      • replace() (all overloads)

      Attachments

        For Gerrit Dashboard: QTBUG-106184
        # Subject Branch Project Status CR V

        Activity

          People

            cnn Qt Core & Network
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There is 1 open Gerrit change