Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-106185

QByteArray: don't detach in replace()

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • None
    • 8
    • 2753924fc (dev), a5bafadf8 (6.9), 7e53636c5 (6.8)

    Description

      After we've detected that we need to change the container in replace(), don't detach(). Instead, check if we're shared. If we're not shared, and the replacee is larger than the replacer, do the change in-place. Otherwise, make a new container, copy the subset that forms the final result over, then assign the new container to *this.

      See epic for more details.

      Acceptance criteria: The following member functions no longer detach:

      • replace() (all overloads)

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-106185
          # Subject Branch Project Status CR V

          Activity

            People

              cnn Qt Core & Network
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes