Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-106188

QList: don't detach in insert()/append()/prepend()

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      After we've detected that we need to change the container in insert(), don't detach(). Instead, check if we're shared. If we're not shared, and we have sufficient capacity, do the change in-place. Otherwise, make a new container, copy the subset that forms the final result over, then assign the new container to *this.

      See epic for more details.

      Acceptance criteria: The following member functions no longer detach:

      • append() (all overloads)
      • emplace*() (all variants)
      • insert() (all overloads)
      • prepend() (all overloads)
      • push_back()/push_front()

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            cnn Qt Core & Network
            Reporter:
            mmutz Marc Mutz
            PM Owner:
            Vladimir Minenko Vladimir Minenko
            RnD Owner:
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes