Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-106552

qttools: Build failure if litehtml is found on the system

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 6.5.0 Beta1
    • 6.3.2
    • Tools: Assistant
    • None
    • Manjaro Linux
    • 8dee1e2b18 (qt/qttools/dev) 8dee1e2b18 (qt/tqtc-qttools/dev) cc774892b7 (qt/qttools/6.4) cc774892b7 (qt/tqtc-qttools/6.4) dbf8b3893a (qt/qttools/6.3) dbf8b3893a (qt/tqtc-qttools/6.3)

    Description

      Despite QTBUG-105130 being closed, cmake still uses sources from the system's litehtml sources, not those from Qt which leads to a build error:

      /usr/bin/c++ -DLITEHTML_UTF8 -DQLITEHTML_STATIC_LIBRARY -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_JAVA_STYLE_ITERATORS -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qttools/src/assistant/qlitehtml/src/qlitehtml_autogen/include -I/home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qtbase/include -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qtbase/include/QtWidgets -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qtbase/include/QtCore -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qtbase/mkspecs/linux-g++ -I/home/qtrob/dev/g++-12.1.1/qt-6.3.2-nowebengine-r/qtbase/include/QtGui -isystem /usr/include/litehtml -DNDEBUG -O2 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -w -fPIC -std=c++17 -MD -MT qttools/src/assistant/qlitehtml/src/CMakeFiles/qlitehtml.dir/container_qpainter.cpp.o -MF qttools/src/assistant/qlitehtml/src/CMakeFiles/qlitehtml.dir/container_qpainter.cpp.o.d -o qttools/src/assistant/qlitehtml/src/CMakeFiles/qlitehtml.dir/container_qpainter.cpp.o -c /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter.cpp
      In file included from /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter.cpp:30:
      /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter_p.h:99:9: error: 'int DocumentContainerPrivate::pt_to_px(int)' marked 'override', but does not override
         99 |     int pt_to_px(int pt) override;
            |         ^~~~~~~~
      /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter.cpp: In constructor 'DocumentContainer::DocumentContainer()':
      /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter.cpp:461:13: error: invalid new-expression of abstract class type 'DocumentContainerPrivate'
        461 |     : d(new DocumentContainerPrivate)
            |             ^~~~~~~~~~~~~~~~~~~~~~~~
      /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter_p.h:83:7: note:   because the following virtual functions are pure within 'DocumentContainerPrivate':
         83 | class DocumentContainerPrivate final : public litehtml::document_container
            |       ^~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /usr/include/litehtml/litehtml.h:4,
                       from /home/qtrob/dev/src/qt-6.3.2/qttools/src/assistant/qlitehtml/src/container_qpainter_p.h:33:
      /usr/include/litehtml/html.h:42:65: note:     'virtual int litehtml::document_container::pt_to_px(int) const'
         42 |                 virtual int                                     pt_to_px(int pt) const = 0;
            |                                                                 ^~~~~~~~
      [252/2971] Building CXX object qttools...keFiles/qdoc.dir/clangcodeparser.cpp.o
      ninja: build stopped: subcommand failed.
      

      Uninstalling litehtml is not an option because the system's package of Qt Creator depends on it.

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-106552
          # Subject Branch Project Status CR V

          Activity

            People

              jkobus Jarek Kobus
              rlohning Robert Löhning
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes