Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-107191

QQmlJSImporter: Do not mix up cpp and qml names

    XMLWordPrintable

Details

    • c52b7fdca8 (qt/qtdeclarative/dev) c52b7fdca8 (qt/tqtc-qtdeclarative/dev)

    Description

      QQmlJSScope::findType() is used in qqmljsimportvisitor and qqmljsimporter with a contextualtypes. Contextualtypes is a map from string to qml and cpp names, which makes the code pretty confusing to read as one never knows if the current name is a qml type or a cpp type.

      Tasks:

      • find out why qqmljsimporter mixes up composite and non-composite types
      • if it has a good reason: document this strange behavior with internal documentation everywhere it happens
      • Otherwise: refactor ContextualTypes and QQmlJSImporter to separate composite and non-composite types

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            sami.shalayel Sami Shalayel
            sami.shalayel Sami Shalayel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes