Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-107580

[REG 5.15.10 -> 5.15.11], PositionSource: last known position is never read

    XMLWordPrintable

Details

    • Android
    • 3
    • 35e503cbcf (qt/qtpositioning/dev) 4ed9f2f676 (qt/tqtc-qtlocation/5.15) 12614893c9 (qt/qtpositioning/6.4) 12614893c9 (qt/tqtc-qtpositioning/6.4) 35e503cbcf (qt/tqtc-qtpositioning/dev) b6a4940591 (qt/tqtc-qtpositioning/6.2)
    • Foundation Sprint 68

    Description

      When an active PositionSource is created, it is not initialized with the last known position, because the if statement added in : https://codereview.qt-project.org/c/qt/qtpositioning/+/414974 can never be true. PositionSource only becomes active after setActive() has called start() through a QTimer. By then tryAttach() has already been run resulting in an invalid position on startup.

       

       

      if (m_active) {
          const QGeoPositionInfo &lastKnown = m_positionSource->lastKnownPosition();
          if (lastKnown.isValid())
              setPosition(lastKnown);
      }
      

       

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ivan.solovev Ivan Solovev
            p.krug Patrick Krug
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes