Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-109520

Review toupper use [QWindowsKeyMapper]

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: P2: Important P2: Important
    • 6.4.3, 6.5.0, 6.6.0
    • None
    • QPA: Windows
    • None
    • Windows
    • 3
    • 7a6016aec (dev), 3d386dea2 (6.5), 2ab5df884 (6.4)
    • Foundation Sprint 72

      This is a spin off from QTBUG-109235, please see there for more info.

      I have a hard time deciding whether the toupper() call here:

      qtbase/src/plugins/platforms/windows/qwindowskeymapper.cpp:        a = toupper(a);
      

      is genuinely supposed to map i to İ} in the Türkiye locale, or whether it shouldn't still be {{I. If it is, then the code is wrong, because touppper('i') will likely return 'i', then, since İ isn't representable. So the code is wrong, either way. The question is what the fix should be.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes