Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-109790

C++ syncqt ignores the wrong line with ELFVERSION:ignore-next

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P1: Critical P1: Critical
    • 6.5.0 RC, 6.5.0, 6.6.0
    • 6.5.0 Beta1
    • Build System
    • None
    • ad7ad62d1 (dev), 1ee479c66 (6.5), dd7931d58 (dev), 4ed94a237 (6.5)

      I think the issue is parseVersionScriptContent is only passed code lines, so the if the line containing the ELFVERSION marker contains no code, the current line is the next one after that, which means the next line is two code lines further.

      Debugging from syncqt on parsing qthread_p.h, with the ELFVERSION marker from https://codereview.qt-project.org/c/qt/qtbase/+/451705 :

      qthread_p.h: class QPostEventList : public QList<QPostEvent>
      qthread_p.h: ;
      line ignored: ;
      

      This is also the reason why QTextCodec is marked as a private symbol:

      qtextcodec_p.h
      #else // without textcodec:
      
      // ELFVERSION:ignore-next
      class QTextCodec
      

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            semlanik Alexey Edelev
            thiago Thiago Macieira
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes