Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111040

QVarLengthArray is missing std::launder()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Invalid
    • P2: Important
    • None
    • 5.15.12, 6.2.6, 6.4.2, 6.5.0 Beta2
    • None
    • 3
    • Foundation Sprint 75, Foundation Sprint 76

    Description

      See epic for more information.

      QVLA is using a char array as internal storage, so we need to launder() at least when elements could be residing in internal storage ("std::optional" pattern in the epic), but not when elements are from heap storage!

      Update 2023-02-15: C++17 needs the launder() also when placing new objects, just in case the value_type contains const or reference members, and we emplace_back() over a previously pop_back()'ed element.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes