Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111053

Port QtCharts examples away from inheriting QTextStream

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: P2: Important P2: Important
    • 6.5.2, 6.6
    • 6.5.0 Beta2
    • Charts, Examples and Demos
    • None
    • All
    • 8f4629814 (dev), cf7c6bd49 (6.5)

      For QTBUG-111051, we'd like to (optionally) make QTextStream final. This clashes with the QtChart's example's inheriting from QTextStream. This code seems to be the only in-tree user that inherits QTextStream.

      ~/Qt/qt5$ git grep --recurse-submodules  -E ' : *(public|private|protected)? +QTextStream'
qtbase/src/corelib/serialization/qtextstream.cpp:        setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \
qtbase/src/corelib/serialization/qtextstream.cpp:        setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \
qtcharts/examples/charts/boxplotchart/boxdatareader.h:class BoxDataReader : public QTextStream
qtcharts/examples/charts/candlestickchart/candlestickdatareader.cpp:    : QTextStream(device)
qtcharts/examples/charts/candlestickchart/candlestickdatareader.h:class CandlestickDataReader : public QTextStream

        For Gerrit Dashboard: QTBUG-111053
        # Subject Branch Project Status CR V
        478724,19 Revamp examples dev qt/qtcharts Status: MERGED +2 0
        484476,3 Revamp examples 6.5 qt/qtcharts Status: MERGED +2 0

            e0348803 Miikka Heikkinen
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes