Details
-
Task
-
Resolution: Fixed
-
P2: Important
-
6.5.0 Beta2
-
None
-
All
-
8f4629814 (dev), cf7c6bd49 (6.5)
Description
For QTBUG-111051, we'd like to (optionally) make QTextStream final. This clashes with the QtChart's example's inheriting from QTextStream. This code seems to be the only in-tree user that inherits QTextStream.
~/Qt/qt5$ git grep --recurse-submodules -E ' : *(public|private|protected)? +QTextStream' qtbase/src/corelib/serialization/qtextstream.cpp: setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \ qtbase/src/corelib/serialization/qtextstream.cpp: setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \ qtcharts/examples/charts/boxplotchart/boxdatareader.h:class BoxDataReader : public QTextStream qtcharts/examples/charts/candlestickchart/candlestickdatareader.cpp: : QTextStream(device) qtcharts/examples/charts/candlestickchart/candlestickdatareader.h:class CandlestickDataReader : public QTextStream
Attachments
Issue Links
- blocks
-
QTBUG-111051 QTextStream shouldn't have been polymorphic
-
- Closed
-
| For Gerrit Dashboard: QTBUG-111053 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 478724,19 | Revamp examples | dev | qt/qtcharts | Status: MERGED | +2 | 0 |
| 484476,3 | Revamp examples | 6.5 | qt/qtcharts | Status: MERGED | +2 | 0 |