Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111053

Port QtCharts examples away from inheriting QTextStream

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P2: Important
    • 6.5.2, 6.6
    • 6.5.0 Beta2
    • Charts, Examples and Demos
    • None
    • All
    • 8f4629814 (dev), cf7c6bd49 (6.5)

    Description

      For QTBUG-111051, we'd like to (optionally) make QTextStream final. This clashes with the QtChart's example's inheriting from QTextStream. This code seems to be the only in-tree user that inherits QTextStream.

      ~/Qt/qt5$ git grep --recurse-submodules  -E ' : *(public|private|protected)? +QTextStream'
qtbase/src/corelib/serialization/qtextstream.cpp:        setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \
qtbase/src/corelib/serialization/qtextstream.cpp:        setStatus(atEnd() ? QTextStream::ReadPastEnd : QTextStream::ReadCorruptData); \
qtcharts/examples/charts/boxplotchart/boxdatareader.h:class BoxDataReader : public QTextStream
qtcharts/examples/charts/candlestickchart/candlestickdatareader.cpp:    : QTextStream(device)
qtcharts/examples/charts/candlestickchart/candlestickdatareader.h:class CandlestickDataReader : public QTextStream

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-111051 QTextStream shouldn't have been polymorphic

          • P4: Low - Would be nice to fix, but it's not very important.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              e0348803 Miikka Heikkinen
              mmutz Marc Mutz
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes