Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111262

Review <ctype.h> uses [Qt]

    XMLWordPrintable

Details

    • 8
    • f6b780b58 (dev), eee36a6ed (6.5)

    Description

      The <cctype> functions are locale-dependent. Also, they require that the argument is 0..255 or EOF, so it's UB to even feed a char! You need to cast to uchar first! So, basically all our uses of <cctype> functions are UB!

      Please check your respective code bases, book patches, if any, onto this ticket, and, once merged, remove your component from the Jira field.

      QTBUG-109235 dealt with toupper/tolower, specifically. This ticket is about all the other <cctype> functions, e.g. isprint().

      Attachments

        Issue Links

          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-109235 Review toupper/tolower uses [Qt]

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-111262
          # Subject Branch Project Status CR V
          466935,5 QtMiscUtils: add isAsciiPrintable() helper dev qt/qtbase Status: MERGED +2 0
          467524,2 QtMiscUtils: add isAsciiPrintable() helper 6.5 qt/qtbase Status: MERGED +2 0

          Activity

            People

              cnn Qt Core & Network
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes