Loading...

XML

Word

Printable

Type: Suggestion
Resolution: Fixed
Priority: P3: Somewhat important
Fix Version/s: 6.6.0
Affects Version/s: 6.5.0 Beta3
Component/s: Core: Containers and Algorithms
Labels:
None

Platform/s:

All
Story Points:
8
Commits:
fd17eaca8 (dev), 21615e8df (tqtc/lts-6.2), b95564822 (dev), 28f56f29b (dev), 7f0a919f4 (tqtc/lts-6.2), b00690030 (tqtc/lts-5.15), 6cc1b01ac (6.5), fa510dab9 (6.4), 133be162c (6.5), eb9c8042c (dev), a1889b2a6 (dev), de3e97088 (dev), 690761a4a (dev)
Sprint:
Foundation Sprint 77, Foundation Sprint 78

QVariant::fromValue<T>() only requires that T is copy-constructible type, but QVariant::value() requires default constructor.

This asymmetric usage is error prone and it would be best to support non-default constructible type with QVariant::value().
If it is not possible, QVariant::fromValue() should be ill-formed for non-default-constructible types.

resulted from

QTBUG-105140 [REG] default constuctor requirement for meta type (QVariant) breaks webengine api

Closed

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-111598
#	Subject	Branch	Project	Status	CR	V
463445,1	QVariant: add an explicit trait check function	dev	qt/qtbase	Status: ABANDONED	-1	0
463780,7	Implement [variant.get] for QVariant [2/2]: get()	dev	qt/qtbase	Status: MERGED	+2	0
464369,2	tst_QVariant: check fromValue() with a non-default-constructible type	dev	qt/qtbase	Status: MERGED	+2	0
464370,7	Implement [variant.get] for QVariant [1/2]: get_if()	dev	qt/qtbase	Status: MERGED	+2	0
464371,5	Short live q23::forward_like!	dev	qt/qtbase	Status: MERGED	+2	0
464491,2	QDBusError: don't refer to a QT_NAMESPACE'ed get() as ::get()	dev	qt/qtbase	Status: MERGED	+2	0
464508,2	tst_QVariant: check fromValue() with a non-default-constructible type	6.5	qt/qtbase	Status: MERGED	+2	0
464509,2	tst_QVariant: check fromValue() with a non-default-constructible type	6.4	qt/qtbase	Status: MERGED	+2	0
464518,2	tst_QVariant: check fromValue() with a non-default-constructible type	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
464649,1	QDBusError: don't refer to a QT_NAMESPACE'ed get() as ::get()	6.4	qt/qtbase	Status: ABANDONED	+2	0
464650,2	QDBusError: don't refer to a QT_NAMESPACE'ed get() as ::get()	6.5	qt/qtbase	Status: MERGED	+2	0
464651,2	QDBusError: don't refer to a QT_NAMESPACE'ed get() as ::get()	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
464652,2	QDBusError: don't refer to a QT_NAMESPACE'ed get() as ::get()	tqtc/lts-5.15	qt/tqtc-qtbase	Status: MERGED	+2	0
466776,8	Short live QT_ENABLE_P0846_SEMANTICS_FOR!	dev	qt/qtbase	Status: MERGED	+2	0
468015,3	Verify fix for manual get<I> calls for QVector<N>D	dev	qt/qtbase	Status: MERGED	+2	0
468087,2	tst_QVariant: add a test contrasting Qt 5/6 isNull behavior	dev	qt/qtbase	Status: MERGED	+2	0