Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111604

update or remove qt3d's bundled assimp

    XMLWordPrintable

Details

    • a7673ce565a1831d96ff936a6cba22f19fc3ff66

    Description

      The assimp linked as a submodule from qt3d is outdated (from 2021). Either update the version to match what qtquick3d has, or remove the submodule, and the build system for it.

      janihe, mkrus: How did this sneak though QTBUG-116235? 

      Original description:

      Attempted fix not accepted: https://codereview.qt-project.org/c/qt/qt3d/+/453372

      /home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp: In function ‘void Assimp::FBX::TokenizeBinary(TokenList&, const char*, size_t)’:
/home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp:475:61: error: ‘uint32_t’ is not a member of ‘std’; did you mean ‘wint_t’?
  475 |         if (!is64bits && (length > std::numeric_limits<std::uint32_t>::max())) {
      |                                                             ^~~~~~~~
      |                                                             wint_t
/home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp:475:69: error: template argument 1 is invalid
  475 |         if (!is64bits && (length > std::numeric_limits<std::uint32_t>::max())) {

      Already fixed upstream. Just need to update it.

      Attachments

        Issue Links

          is required for

          Task - A task that needs to be done. QTQAINFRA-5045 Update MinGW used in CI

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          Sub-task - The sub-task of the issue QTBUG-116235 Qt 6.6.0: 3rd party component update: Qt3D

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Sub-task - The sub-task of the issue QTBUG-121324 Qt 6.7.0: 3rd party component update: Qt3D

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-119066 Standard compilation of 3D fails due to AssetLib/FBX (3rd party) error

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              seanharmer Sean Harmer
              thiago Thiago Macieira
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes