Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111604

update or remove qt3d's bundled assimp

XMLWordPrintable

    • a7673ce565a1831d96ff936a6cba22f19fc3ff66

      The assimp linked as a submodule from qt3d is outdated (from 2021). Either update the version to match what qtquick3d has, or remove the submodule, and the build system for it.

      janihe, mkrus: How did this sneak though QTBUG-116235? 

      Original description:

      Attempted fix not accepted: https://codereview.qt-project.org/c/qt/qt3d/+/453372

      /home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp: In function ‘void Assimp::FBX::TokenizeBinary(TokenList&, const char*, size_t)’:
/home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp:475:61: error: ‘uint32_t’ is not a member of ‘std’; did you mean ‘wint_t’?
  475 |         if (!is64bits && (length > std::numeric_limits<std::uint32_t>::max())) {
      |                                                             ^~~~~~~~
      |                                                             wint_t
/home/tjmaciei/src/qt/qt6-release/qt3d/src/3rdparty/assimp/src/code/AssetLib/FBX/FBXBinaryTokenizer.cpp:475:69: error: template argument 1 is invalid
  475 |         if (!is64bits && (length > std::numeric_limits<std::uint32_t>::max())) {

      Already fixed upstream. Just need to update it.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            seanharmer Sean Harmer
            thiago Thiago Macieira
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes