Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111674

Give QMessageAuthenticationCode some TLC

    XMLWordPrintable

Details

    • Epic
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • None
    • QMessageAuthenticationCode-TLC

    Description

      QMessageAuthenticationCode is like QCryptographicHash + key. These classes should have identical API, apart from the additional key for QMessageAuthenticationCode.

      Over the past few releases, QCryptographicHash has seen many improvements to its API and implementation which have, however, not resulted in equivalent changes to QMessageAuthenticationCode. In no particular order:

      • port to QByteArrayView and largely noexcept operations with fixed-size internal buffers
      • new OpenSSL3 backend
      • addition of move SMFs
      • hash() optimization (only create Private, not public class, saving d-pointer allocation)

      Implement these for QMessageAuthenticationCode, too.

      Already merged is the move of qmessageauthenticationcode.cpp into qcryptographichash.cpp so QMessageAuthenticationCode can use QCryptographicHashPrivate, and the hash() optimization.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            cnn Qt Core & Network
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes