Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-11194

Typo in qfontdatabase_s60.cpp

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 4.7.0
    • 4.6.0, 4.6.1, 4.6.2, 4.7.0
    • GUI: Font handling
    • None
    • 7d71e65658d27c200f97b93781c3c7f7c313ff56

    Description

      There is a typo in src/gui/text/qfontdatabase_s60.cpp as follows.

      src/gui/text/qfontdatabase_s60.cpp
      const QFontEngineS60Extensions *QFontDatabaseS60StoreImplementation::extension(const QString &typeface) const
      {
      // snip
              const CBitmapFont *bitmapFont = static_cast<CBitmapFont*>(font);
              COpenFont *openFont = 
      #ifdef FNTSTORE_H_INLINES_SUPPORT_FMM
                  bitmapFont->openFont(); // *** MUST BE bitmapFont->OpenFont(); ***
      #else
                  OpenFontFromBitmapFont(bitmapFont);
      #endif // FNTSTORE_H_INLINES_SUPPORT_FMM
      // snip
      

      The above code is okay if FNTSTORE_H_INLINES_SUPPORT_FMM is not defined as the code above around the typo won't be compiled. However, once FNTSTORE_H_INLINES_SUPPORT_FMM is defined somewhere, the code will fail to compile as CFbsBitmapFont has not openFont() API but OpenFont().

      Ref.
      http://library.forum.nokia.com/index.jsp?topic=/S60_5th_Edition_Cpp_Developers_Library/GUID-35228542-8C95-4849-A73F-2B4F082F0C44/sdk/doc_source/reference/reference-cpp/Font_and_Bitmap_Server/CFbsFontClass.html

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            portale Alessandro Portale
            uichi TAKAHASHI Uichiro
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes