Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: P1: Critical
Fix Version/s: 5.15.15, 6.5.2, 6.6.0
Affects Version/s: 5.15.9, 6.3.2, 6.4.3, 6.5.0
Component/s: Build System: CMake, Tools: Linguist
Labels:
None

Platform/s:

All
Commits:
d2eaccfe7 (dev), 0b75e045d (6.5), c04dd1721 (tqtc/lts-5.15)

Description

Resulted from https://github.com/opentoonz/opentoonz/issues/4831

In the opentoonz projects, translations are structured by directory instead of by name:

toonz/sources/translations/chinese/toonz.ts
toonz/sources/translations/czech/toonz.ts
toonz/sources/translations/french/toonz.ts
toonz/sources/translations/german/toonz.ts
toonz/sources/translations/italian/toonz.ts
toonz/sources/translations/japanese/toonz.ts
toonz/sources/translations/korean/toonz.ts
toonz/sources/translations/norwegian_bokmal/toonz.ts
toonz/sources/translations/russian/toonz.ts
toonz/sources/translations/spanish/toonz.ts

This breaks qt5_add_translation since https://codereview.qt-project.org/c/qt/qttools/+/396194 with the following error:

  Attempt to add a custom rule to output

    /build/opentoonz/src/build/tnzcore/.lupdate/tnzcore.ts.stamp.rule

  which already has a custom rule.
Call Stack (most recent call first):
  CMakeLists.txt:604 (qt5_create_translation)
  tnzcore/CMakeLists.txt:262 (add_translation)

Attachments

Issue Links

resulted from

QTBUG-96549 make clean removes ts file when using qt5_create_translation()

Closed

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-113152
#	Subject	Branch	Project	Status	CR	V
474237,6	CMake: Fix qt6_create_translation for same-named .ts files	dev	qt/qttools	Status: MERGED	+2	0
480249,2	CMake: Fix qt6_create_translation for same-named .ts files	6.5	qt/qttools	Status: MERGED	+2	0
480253,4	CMake: Fix qt5_create_translation for same-named .ts files	tqtc/lts-5.15	qt/tqtc-qttools	Status: MERGED	+2	0