Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-113460

Align windows screen capturing functionality

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P2: Important
    • None
    • None
    • Multimedia
    • None
    • Windows
    • 0a6f667a5 (dev), 9d8109632 (6.5), f23ac5157 (dev), 193d7e1bf (dev), 0b013d6df (6.5), 1dc73b38a (6.5), 2d65ac72a (dev), 9b38bc514 (dev), cfc5b97da (dev), 0d707c5c9 (6.5), c5313d099 (6.5), 1b7d01685 (6.5), 59a50bebb (dev), 565950c5c (6.6), 4f44e430d (6.5)

    Description

      Currently, the windows screen capturing implementation is a bit hairy and the tests are blacklisted on CI.
      What would be great to carry out:

      • Make screen capturing tests pass on dev branch and 6.5
      • Make windows app capturing tests pass on the dev branch (it's not included to 6.5).
      • Refactor the main windows implementation (QFFmpegScreenCaptureDxgi) with QFFmpegScreenCaptureThread. See QX11ScreenCapture, QAVFScreenCapture as samples.
      • Revisit QFFmpegScreenCaptureUwp implementation. Currently it's not used since it's pretty unstable: crashes on some types of windows (e.g. on win10), makes a yellow frame around the captured screen,  on some types of windows makes the whole screen darker.
        Probably, we shouldn't use QFFmpegScreenCaptureUwp at all, especially if the main impl is stable and has the same performance. Note, QFFmpegScreenCaptureThread contains simple performance measurement under the hood, see logs.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-103226 Window Screen capturing feature for QtMultimedia

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Task - A task that needs to be done. QTBUG-113784 Keep screen textures on GPU during screen capture

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-113460
          # Subject Branch Project Status CR V
          479113,4 WIP: Simplify white-box unit testing in QFFmpegMediaPlugin dev qt/qtmultimedia Status: NEW -2 0
          476891,2 Refactor DxgiScreenGrabberActive to inherit from QFFmpegScreenCaptureThread dev qt/qtmultimedia Status: DEFERRED 0 0
          476892,2 Make QFFmpegScreenCaptureThread frame rate setter/getter protected dev qt/qtmultimedia Status: ABANDONED 0 0
          476893,2 Remove DxgiScreenGrabberActive m_maxFrameRate member dev qt/qtmultimedia Status: ABANDONED 0 0
          476894,2 Pass screen instead of frame rate to QFFmpegScreenCaptureDxgi ctor dev qt/qtmultimedia Status: ABANDONED 0 0
          476895,2 Associate DirectX context mutex with DxgiScreenGrabberActive dev qt/qtmultimedia Status: ABANDONED 0 0
          476896,2 Make frame time stamps members of DxgiScreenGrabberActive dev qt/qtmultimedia Status: ABANDONED 0 0
          476897,2 Extract member function that calculates the duration of frame dev qt/qtmultimedia Status: ABANDONED 0 0
          476898,2 Introduce an m_frameSize member in DxgiScreenGrabberActive dev qt/qtmultimedia Status: ABANDONED 0 0
          476899,2 Avoid accessing local variable 'format' in grabber loop dev qt/qtmultimedia Status: ABANDONED 0 0
          476900,2 Extract grabFrame implementation in DxgiScreenGrabberActive dev qt/qtmultimedia Status: ABANDONED 0 0
          476901,2 Use timer based approach in DxgiScreenGrabberActive dev qt/qtmultimedia Status: ABANDONED 0 0
          476902,2 Remove duplicate debug logging from DXGI grabber dev qt/qtmultimedia Status: ABANDONED 0 0
          476903,2 Implement QFFmpegScreenCaptureDxgi using common base class dev qt/qtmultimedia Status: ABANDONED 0 0
          476904,2 Simplify stopping the DxgiScreenGrabberActive thread dev qt/qtmultimedia Status: ABANDONED 0 0
          476905,2 Harmonize naming of DXGI screen grabber thread implementation dev qt/qtmultimedia Status: ABANDONED 0 0
          476906,2 Rename m_active member to m_grabber in QFFmpegScreenCaptureDxgi dev qt/qtmultimedia Status: ABANDONED 0 0
          476951,5 Implement QFFmpegScreenCaptureDxgi in terms of common FFMPeg base class dev qt/qtmultimedia Status: MERGED +2 0
          477043,4 Improve naming of screen capture integration tests dev qt/qtmultimedia Status: MERGED +2 0
          477272,2 Implement QFFmpegScreenCaptureDxgi in terms of common FFMPeg base class 6.5 qt/qtmultimedia Status: MERGED +2 0
          477657,5 Rename QWindowsIUPointer template class to QComPtr dev qt/qtmultimedia Status: MERGED +2 0
          477658,4 Rename file qwindowsiuptr_p.h to qcomptr_p.h dev qt/qtmultimedia Status: MERGED +2 0
          477659,2 Merge rename QWindowsIUPointer to QComPtr dev qt/qtmultimedia Status: ABANDONED -1 0
          477941,2 Rename QWindowsIUPointer template class to QComPtr 6.5 qt/qtmultimedia Status: MERGED +2 0
          477982,2 Rename file qwindowsiuptr_p.h to qcomptr_p.h 6.5 qt/qtmultimedia Status: MERGED +2 0
          478728,5 Simplify white-box unit testing in QFFmpegMediaPlugin dev qt/qtmultimedia Status: ABANDONED 0 0
          479569,3 Do not capture frames unless the screen bitmap has changed dev qt/qtmultimedia Status: ABANDONED 0 0
          479662,4 Make getNextFrame function part of DXGI grabber dev qt/qtmultimedia Status: MERGED +2 0
          479663,5 Release DXGI duplication frame as late as possible to favor performance dev qt/qtmultimedia Status: MERGED +2 0
          480549,3 Improve naming of screen capture integration tests 6.5 qt/qtmultimedia Status: MERGED +2 0
          480551,2 Make getNextFrame function part of DXGI grabber 6.5 qt/qtmultimedia Status: MERGED +2 0
          480553,2 Release DXGI duplication frame as late as possible to favor performance 6.5 qt/qtmultimedia Status: MERGED +2 0
          482291,3 Avoid flooding log during DXGI screen capture error handling dev qt/qtmultimedia Status: MERGED +2 0
          482359,2 Avoid flooding log during DXGI screen capture error handling 6.6 qt/qtmultimedia Status: MERGED +2 0
          482360,2 Avoid flooding log during DXGI screen capture error handling 6.5 qt/qtmultimedia Status: MERGED +2 0

          Activity

            People

              jogerh Jøger Hansegård (Inactive)
              artemiy Artem Dyomin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There is 1 open Gerrit change