Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-113725

Findings for qmlls



    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.6.0 FF
    • 6.6
    • QML: Tooling
    • None
    • 7a4175ff6 (dev)


      I have been playing around with qmlls and its document format requests. Here are some unexpected results I encountered.

      1. After typing out a simple but valid qml file, it is marked as invalid and formatting fails. Invoking qmlformat directly works as expected. See New.{mp4,qml}
      2. Formatting removes the escape character in the key string of a key-value pair of an object. See Escape.{mp4,qml}
      3. Some requests cause an assertion failure and then never finish unless interrupted by the user. See Infinite.{mp4,qml}
      4. Formatting is performed on the last valid state of the document leading to some spooky behavior such as adding additional braces or bringing deleted code back. For some reason, in the example code, the presence of the comment at the end of the line also has an importance in triggering the issue. See Spooky.{mp4,qml}

      I have used patchset 10 of semih.yavuz 's work here https://codereview.qt-project.org/c/qt/qtdeclarative/+/475123/10 cherry-picked on top of 36e3ea45f9df38ee0f2e1e619a8c344357d56896 from dev


        1. Escape.mp4
          1.92 MB
        2. Escape.qml
          0.1 kB
        3. Infinite.mp4
          1.38 MB
        4. Infinite.qml
          0.0 kB
        5. New.mp4
          6.15 MB
        6. New.qml
          0.0 kB
        7. Spooky.mp4
          5.75 MB
        8. Spooky.qml
          0.2 kB

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.



              semih.yavuz Semih Yavuz
              olivier.decanniere Olivier De Cannière
              0 Vote for this issue
              4 Start watching this issue



                Gerrit Reviews

                  There are no open Gerrit changes