Details
-
Bug
-
Resolution: Fixed
-
P3: Somewhat important
-
6.6
-
None
-
-
6c40b6160 (dev), 9a31ac479 (6.5), f03e39cb5 (6.6)
Description
I recently did a git clone ~/bare/qt/qt5.git/ in which tab-completion on the command-line had helpfully included a trailing slash. I used init-repository --mirror ~/bare/qt/ (in which the trailing / is required and correct) to set up all the sub-modules, only to find that the origin remote of each sub-module referred to non-existent ~/bare/qt/qt5.git/qtbase.git and similar, with a spurious qt5.git/ path-component.
The origin of the top level module was ~/bare/qt/qt5.git/, retaining the trailing / from the command-line, so I suspect init-repository failed to properly clean that up.
Each sub-module's mirror remote had the correct path to the remote in the mirror, from which it had clearly been cloned.
This this happens naturally when cloning from a local mirror, thanks to command-line completion, it is an annoyance for anyone using this script with a local mirror, which it is supposed to support.
Attachments
For Gerrit Dashboard: QTBUG-113793 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
480777,3 | init-repository: Fix wrong remote URLs in cloned submodules | dev | qt/qt5 | Status: MERGED | +2 | 0 |
484442,2 | init-repository: Fix wrong remote URLs in cloned submodules | 6.6 | qt/qt5 | Status: MERGED | +2 | 0 |
484443,2 | init-repository: Fix wrong remote URLs in cloned submodules | 6.5 | qt/qt5 | Status: MERGED | +2 | 0 |