Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-114367

QtPdf API review findings

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3: Somewhat important
    • None
    • 6.6.0
    • PDF
    • None
    • All
    • 733780d34 (dev), 8cbe13a4f (6.6)

    Description

      QPdfLinkModel has a private member var:

      private:
    QHash<int, QByteArray> m_roleNames;
    Q_DECLARE_PRIVATE(QPdfLinkModel)

      besides the d which could be in QPdfLinkModelPrivate or maybe even static.

      QPdfPageSelector has a separate d-member with a QPdfPageSelector Private..
      QSpinBoxPrivate is not exposed as a qspinbox_p.h..otherwise, the normal mechanism inheriting QSpinBoxPrivate could be used. Not sure if it is worth the hassle.

      Attachments

        Issue Links

          is required for

          Task - A task that needs to be done. QTBUG-114214 Qt 6.6 API Change Review

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-114367
          # Subject Branch Project Status CR V
          484692,2 Move QPdfLinkModel::m_roleNames to QPdfLinkModelPrivate dev qt/qtwebengine Status: MERGED +2 0
          485869,2 Move QPdfLinkModel::m_roleNames to QPdfLinkModelPrivate 6.6 qt/qtwebengine Status: MERGED +2 0

          Activity

            People

              srutledg Shawn Rutledge
              kleint Friedemann Kleint
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes