Details
-
Task
-
Resolution: Fixed
-
P3: Somewhat important
-
None
-
None
-
3
-
bd40a67aa (dev), 433e5223d (6.6), 97adda867 (dev), c70257e9b (dev), 8c2c4f178 (dev), 3748b194d (dev), d18a9dd97 (dev), eb1cec404 (6.6), 3d70617c7 (6.6), 74571f345 (6.6), 90d96766a (6.6), acaf9b0d2 (6.6), d8a8a3a5d (dev), 3cc188537 (6.6), 416e07e05 (dev)
-
Foundation Sprint 85, Foundation Sprint 86
Description
QEventLoopLockerPrivate consists of only a union of three pointers and a discriminator tag which would fit into the LSBs of the pointer values, so it doesn't really pull its weight. We should put tag and pointer value into the QEventLoopLocker's d-pointer directly, then, and get rid of the Private.
Attachments
Issue Links
- resulted in
-
-
- Closed
-
| For Gerrit Dashboard: QTBUG-114793 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 489019,3 | QEventLoopLocker: unexport | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489020,3 | QEventLoopLockerPrivate: store the tag in the pointer variable | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489061,2 | QEventLoopLocker: add a visit() member | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489062,3 | QEventLoopLocker: use visit() to DRY ctors | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489063,3 | QEventLoopLocker: defend against nullptr arguments | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489064,2 | QCoreApplication: mark instance() as noexcept | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489065,3 | QEventLoopLocker: inline Private into public class | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489249,2 | QCoreApplication: mark instance() as noexcept | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 489419,2 | QEventLoopLocker: unexport | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 489468,2 | QEventLoopLockerPrivate: store the tag in the pointer variable | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 489469,3 | QEventLoopLocker: add a visit() member | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 489512,3 | QEventLoopLocker: rewrite to hold public classes | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 489521,3 | QEventLoopLocker: use visit() to DRY ctors | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 489522,3 | QEventLoopLocker: defend against nullptr arguments | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 490177,2 | QEventLoopLocker: inline Private into public class | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 490331,2 | QEventLoopLocker: rewrite to hold public classes | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |