Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-11475 QtScript's patches to JavaScriptCore
  3. QTBUG-11480

[QtScript/JavaScriptCore] Create script objects of type QScriptObject rather than JSC::Object

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Done
    • P2: Important
    • None
    • Qt Script
    • None

    Description

      http://gitorious.org/+qtwebkit-developers/qtwebkit/qtwebkit-qtscript-integration/commit/762ef344fdc678807fe9a63ab7d48b1f0b4c168c

      This is a very intrusive change that obviously stands no chance of being upstreamed as-is.
      Changing JavaScriptCore to being able to customize the type of object that's constructed by the new operator is technically feasible, but is likely to have performance impact.

      If the patch is dropped, the impact will be that it's no longer possible to change the class (QScriptValue::setClass()) of objects created by "new Object" from JS, only those created by QScriptEngine::newObject().
      This will impact the QtScript bindings generator examples, but we can change those. I don't know if any customers rely on it. They would have to switch to e.g. calling a "Qt.newObject" function from JS that creates an object of type QScriptObject.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kenthans Kent Hansen (Inactive)
            kenthans Kent Hansen (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes