Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-1155

MakefileGenerator::writeSubTargets unnecessary variable name

    XMLWordPrintable

Details

    Description

      In MakefileGenerator::writeSubTargets the code section:
      //don't need the makefile arg if it isn't changed
      QString makefilein;
      if(subtarget->makefile != "$(MAKEFILE)")
      makefilein = " f " + subtarget>makefile;

      This would simply not work when $(MAKEFILE) is not "Makefile".
      Therefore this should be:
      if(subtarget->makefile != "Makefile")
      makefilein = " f " + subtarget>makefile;

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            stormols Marius Storm-Olsen
            admin Administrator
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes