Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-116542

[QtScxml] Fix all binding loops caused by misuse of bindable properties

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P2: Important
    • 6.5.4, 6.6.1, 6.7.0 FF
    • 6.5, 6.6.0 FF
    • Core: Other
    • None
    • 8
    • 36c3daa70 (dev), d86fa5e76 (dev), 48a4f0007 (dev), d69b36b28 (6.6), 809020809 (6.6), b6919ced5 (6.5), 24154f43c (6.5), 205e3da5e (dev), 2d14e9a88 (dev), 2d459667f (dev), 77b44612e (dev), 9f5e13842 (6.6), cbd02e02b (6.6), 1e3b63eff (6.6), 9c82ddc99 (6.6)
    • Foundation Sprint 92

    Description

      Fix all properties that will fail the test implemented in QTBUG-116345.

      In general case, the fix would be as simple as calling valueBypassingBindings() instead of simply accessing the property in the setter (see the epic for a code example).

      The scope of this task is to implement fixes in qtscxml submodule.

      Using git-grep, I managed to get the following list of files that contain bindable properties:

      ~/qt5/qtscxml$ git grep -rI --name-only --recurse-submodules "Q_OBJECT_COMPAT_PROPERTY\|Q_OBJECT_COMPUTED_PROPERTY\|Q_OBJECT_BINDABLE_PROPERTY"
src/scxml/qscxmldatamodel_p.h
src/scxml/qscxmlstatemachine_p.h
src/scxmlqml/eventconnection_p.h
src/scxmlqml/invokedservices_p.h
src/scxmlqml/statemachineloader_p.h
src/statemachine/gui/qbasickeyeventtransition.cpp
src/statemachine/gui/qbasicmouseeventtransition.cpp
src/statemachine/qabstractstate_p.h
src/statemachine/qabstracttransition_p.h
src/statemachine/qeventtransition_p.h
src/statemachine/qhistorystate_p.h
src/statemachine/qsignaltransition_p.h
src/statemachine/qstate_p.h
src/statemachine/qstatemachine_p.h
src/statemachineqml/finalstate_p.h
src/statemachineqml/signaltransition_p.h
src/statemachineqml/state_p.h
src/statemachineqml/statemachine_p.h

      If it turns out that some of the classes are missing the tests for bindable properties, or if the tests do not use the QTestPrivate helpers, then the missing tests should be added.

      Attachments

        Issue Links

          clones

          Task - A task that needs to be done. QTBUG-116541 [QtPositioning] Fix all binding loops caused by misuse of bindable properties

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          depends on

          Task - A task that needs to be done. QTBUG-116345 Identify all bindable properties that cause binding loops

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is cloned by

          Task - A task that needs to be done. QTBUG-116543 [QtSensors] Fix all binding loops caused by misuse of bindable properties

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-117865 QScxmlCompiler memleaks when compiling certains state machines

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          For Gerrit Dashboard: QTBUG-116542
          # Subject Branch Project Status CR V
          499971,4 QScxmlStateMachine: adjust the test and fix binding loops dev qt/qtscxml Status: MERGED +2 0
          508825,2 QScxmlEventConnection: fix binding loops dev qt/qtscxml Status: MERGED +2 0
          508826,2 QScxmlInvokedServices: fix binding loops dev qt/qtscxml Status: MERGED +2 0
          508827,2 QScxmlStateMachineLoader: fix binding loops - simple cases dev qt/qtscxml Status: MERGED +2 0
          509279,4 QScxmlInvokedServices: fix binding loops 6.6 qt/qtscxml Status: MERGED +2 0
          509306,3 Qt StateMachine: fix binding loops dev qt/qtscxml Status: MERGED +2 0
          509423,2 QScxmlEventConnection: fix binding loops 6.6 qt/qtscxml Status: MERGED +2 0
          509424,2 QScxmlStateMachineLoader: fix binding loops - simple cases 6.6 qt/qtscxml Status: MERGED +2 0
          509468,3 SignalTransition: fix binding loops dev qt/qtscxml Status: MERGED +2 0
          509801,3 Fix QScxmlStateMachineLoader::source binding loop dev qt/qtscxml Status: MERGED +2 0
          509828,2 QScxmlEventConnection: fix binding loops 6.5 qt/qtscxml Status: MERGED +2 0
          509829,2 QScxmlStateMachineLoader: fix binding loops - simple cases 6.5 qt/qtscxml Status: MERGED +2 0
          510084,2 QScxmlStateMachine: adjust the test and fix binding loops 6.6 qt/qtscxml Status: MERGED +2 0
          510085,2 Qt StateMachine: fix binding loops 6.6 qt/qtscxml Status: MERGED +2 0
          510086,2 Fix QScxmlStateMachineLoader::source binding loop 6.6 qt/qtscxml Status: MERGED +2 0
          510087,2 SignalTransition: fix binding loops 6.6 qt/qtscxml Status: MERGED +2 0
          510149,2 QScxmlInvokedServices: fix binding loops 6.5 qt/qtscxml Status: MERGED +2 0
          510161,2 SignalTransition: fix binding loops 6.5 qt/qtscxml Status: MERGED +2 0
          510162,2 Fix QScxmlStateMachineLoader::source binding loop 6.5 qt/qtscxml Status: MERGED +2 0
          510163,2 Qt StateMachine: fix binding loops 6.5 qt/qtscxml Status: MERGED +2 0
          510164,2 QScxmlStateMachine: adjust the test and fix binding loops 6.5 qt/qtscxml Status: MERGED +2 0

          Activity

            People

              ivan.solovev Ivan Solovev
              ivan.solovev Ivan Solovev
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: