Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-11475 QtScript's patches to JavaScriptCore
  3. QTBUG-11690

[QtScript/JavaScriptCore] Make Error prototype inherit Error instance

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Done
    • P3: Somewhat important
    • None
    • Qt Script
    • None

    Description

      See http://gitorious.org/+qtwebkit-developers/qtwebkit/qtwebkit-qtscript-integration/commit/892355854c958eec0f8c5ead555fd65a2fc1a6b4

      Reason for patch: ECMA-compliance. ECMA-262, 5th edition, 15.11.7.7: "Each NativeError prototype object is an Error object (its [[Class]] is "Error")".

      Impact of dropping the patch: Without this patch, the QScriptValue::isError() autotest fails (it calls isError() on each of the builtin Error prototype objects).

      Perceived real-world impact of dropping the patch: Little/none. Who relies on this? Code normally handles Error instances, the prototypes are fairly useless (especially since you can't "subclass" Error).

      Suggested action: Try to upstream (the patch needs a testcase).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kenthans Kent Hansen (Inactive)
            kenthans Kent Hansen (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes