Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-116923

Figure out if we need to support dummy gradients still

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P3: Somewhat important
    • 6.8
    • None
    • Graphs: 3D
    • None

    Description

      We had code like this before:

      QList<QQuickGradient *> DeclarativeTheme3D::gradientList()
      {
          QList<QQuickGradient *> list;
          if (m_gradients.isEmpty()) {
              // Create QQuickGradients from theme's gradients
              m_dummyGradients = true;
              for (QLinearGradient &gradient : Q3DTheme::baseGradients())
                  list.append(convertGradient(gradient));
          } else {
              list = m_gradients;
          }    return list;
      } 

      Do we still need this for something? One autotest fails without it (commented out for now), but I fail to see any problems removing it causes in examples and manual tests.

      The main problem in getting that to work is converting QLinearGradient to QQuickGradient.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            oulu_hillbilly Sami Varanka
            tokorpip Tomi Korpipää
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes