Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-117596

Move tab focus specific functionality from QQuickControl to QQuickItem

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • None
    • Quick: Other
    • 43625c714 (dev), 1ca992885 (dev), 64234dfc7 (dev), b37a53798 (dev), a7741ce0f (dev), 99ce38daa (dev), a85791ddf (dev), 58a40b1ab (dev), 57d7c2086 (6.7), eaaf383b5 (6.7), ac0bbf86c (6.7), 881ba6682 (6.7), 644ee4d23 (dev), 12c51fa90 (6.7)

    Description

      This way, all QQuickItem subclasses can have the same focus behaviour and API. Less code to maintain and more consistent API

      Suggestion

      Move

      • QQuickControl::focusReason
      • QQuickControl::focusPolicy

      to QQuickItem

      • make sure that focusReason is properly set when key/mouse events arrive and demands a focus change

       

      Properties that become redundant after the above change (and should probably be deprecated):

      • QQuickItem::activeFocusOnTab
      • QQuickTextInput::activeFocusOnPress
      • QQuickTextEdit::activeFocusOnPress

      Should probably consolidate the code of those two properties into one (calling setActiveFocusOnTab() will set the TabFocus bit into the focusPolicy member, and the same for the other two)

       

      See also https://codereview.qt-project.org/c/qt/qtdeclarative/+/383968

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-117596
          # Subject Branch Project Status CR V

          Activity

            People

              qt.team.quick.subscriptions Qt Quick and Widgets Team
              smd Jan Arve
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated: