Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-11475 QtScript's patches to JavaScriptCore
  3. QTBUG-11761

[QtScript/JavaScriptCore] add UString(QString) constructor and operator QString()

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Invalid
    • P2: Important
    • None
    • Qt Script
    • None

    Description

      Patch: http://gitorious.org/+qtwebkit-developers/qtwebkit/qtwebkit-qtscript-integration/commit/4b9d9aea2a007f0e9fed4221f9401b627405d55f

      Reason: As convenience, avoid having to explicitly call conversion functions.
      There are similar conversions other places in WebKit, e.g. KURL <-> QUrl, IntRect <-> QRect.

      IMO we should get rid of it, since we actually do care where this conversion is done (for performance reasons we want to avoid conversion back and forth).
      So long as the goal is that the QtScript API should not access any of the internal types of JSC anyway, this patch has no place.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kenthans Kent Hansen (Inactive)
            kenthans Kent Hansen (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes