Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-117684

qquickanimation_p_p.h: duplicate vtables

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • None
    • None

    Description

      [see epic for more details; TL;DR: dtors of polymophic classes need to be out-of-line]

      Most classes defined in the file have no out-of-line dtor, so are prone to -Wweak-vtable. It's private API, that's why it's not critical, but it's code hygiene that we should eventually implement.

      As an aside: the template subclasses of polymorphic classes are quite heavyweight constructs. If they're used more than a few dozen times, they should eventually be de-virtualized (cf. QSlotObject or QGenericRunnable for how).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt.team.graphics.and.multimedia Qt Graphics Team
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes