Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-117863

[<other>] Replace QThreadStorage<T> with thread_local T or thread_local optional<T>

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • QPA, QPA: KMS
    • None

    Description

      See epic for more information. Use thread_local T if the object construction is constinit (then add Q_CONSTINIT in front, too), otherwise use thread_local std::optional<T> (and also add Q_CONSTINIT).

      This ticket is about these hits:

      qtbase/src/platformsupport/kmsconvenience/qkmsdevice_p.h:#include <QtCore/QThreadStorage>
qtbase/src/platformsupport/kmsconvenience/qkmsdevice_p.h:    QThreadStorage<AtomicReqs> m_atomicReqs;
qtbase/src/plugins/platforms/ios/optional/nsphotolibrarysupport/qiosfileengineassetslibrary.mm:static QThreadStorage<QString> g_iteratorCurrentUrl;
qtbase/src/plugins/platforms/ios/optional/nsphotolibrarysupport/qiosfileengineassetslibrary.mm:static QThreadStorage<QPointer<QIOSAssetData> > g_assetDataCache;
qtbase/src/plugins/tracing/qctflib_p.h:    QThreadStorage<Channel> m_threadData;

      Acceptance criteria:

      Attachments

        Issue Links

          depends on

          Task - A task that needs to be done. QTBUG-117853 Add QT_NO_QTHREADSTORAGE

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              vestbo Tor Arne Vestbø
              mmutz Marc Mutz
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes