Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-119433

C++20 comparison 6.7 remaining tasks

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P2: Important
    • 6.7.0, 6.8.0 FF
    • 6.7
    • Core: Other
    • None
    • 21
    • 0995358ef (dev), e7a9c8a55 (6.7), aae6cf8d1 (dev), ecafbc4d5 (dev), 1b5211a54 (6.7), b5f1794d4 (6.7), 1353c6f85 (dev), cfc385ce3 (dev), 15aec9a37 (6.7), 84fde7ef2 (6.7), e766a3383 (dev), 4281495f5 (dev), 7eeb96c29 (6.7), bc60c5183 (6.7)
    • Foundations Sprint 98, Foundations Sprint 99, Foundation Sprint 100, Foundation Sprint 101

    Description

      This task is created to collect things that were found during C++20 comparison chain review, but can be most likely addressed after Qt 6.7 FF.

      In no specific order:

      • Think how we can improve the helper functions from QTestPrivate. The problem is that if the test fails, QTestLib points us into the helper function, but not at the actual line of the test that calls this helper function. It becomes tricky if the test has multiple calls to the helper function.
      • Fix documentation comments from https://codereview.qt-project.org/c/qt/qtbase/+/478199/46
      • Try to apply https://codereview.qt-project.org/c/qt/qtbase/+/519927. We seem to have some disagreement about the proper ways of wrapping the macros. So let's postpone it until after FF.
      • Adjusting the docs for the new relational operators. Ideally, qdoc will provide a new command for us.
      • add C array overload of Qt::compareThreeWay
        • what about comparesEqual? We don't have that to specialize, and T[] == T[] will decay instead of iterating over the the elements
          • could just = delete it, people can use std::array as a drop-in replacement in most cases
            • will give us time to rethink this come Qt 6.8
      • Introduce a negation operation for each ordering type so that the symmetric-order implementations for C++17 can simply return the negation of the reversed comparison, instead of needing to cast via strong_ordering.
      • Make qfloat16 relational operators constexpr if QFLOAT16_IS_NATIVE.
      • To be added...

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              ivan.solovev Ivan Solovev
              ivan.solovev Ivan Solovev
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: