Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-119770

Add AST:Node-s representing .import, .pragma in .js files

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • Some future release
    • dev
    • QML: Tooling
    • None

    Description

      Currently when parsing .js files, directives are being handled by lexer with the `QQmlJS::Directives` helper. Afterwards there are no corresponding AST::Node-s, which makes it a bit harder to traverse through or modify those items.

      The other implication that comments related to directives cannot be properly attached to them and being attached to the first AST::Node instead.

      One of the potential proposal is to introduce the corresponding Nodes so that they will be part of the Parsed tree.

      (ref.  Fabian Kosmale: Handling of pragmas and imports in js files )
       

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-118613 dom: fix memory errors when visiting QmlFile::m_astComments

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              qtqmlteam Qt Qml Team User
              dima.a Dmitrii Akshintsev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes