Details
-
Bug
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
6.8
-
04a327f00 (dev), e16db6933 (6.7), fa3c1a020 (6.6), 2074c992a (tqtc/lts-6.5)
Description
After https://codereview.qt-project.org/c/qt/qtbase/+/518683 landed,
trying to call qt-cmake-standalone-test on an in-source auto test (not out-of-source build) like this:
cd qtsvg/tests/manual/examples/svgviewer ~/qt/builds/dev-mac/qtbase/libexec/qt-cmake-standalone-test .
errors out with an endless recursion.
Some debug annotations shows:
>>> CMAKE_CURRENT_SOURCE_DIR /Volumes/T3/Dev/qt/builds/dev-mac/qtbase/lib/cmake/Qt6BuildInternals/QtStandaloneTestTemplateProject >> cuurrent dir /Volumes/T3/Dev/qt/builds/dev-mac/qtbase/lib/cmake/Qt6BuildInternals/QtStandaloneTestTemplateProject >> subdirs /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> cuurrent dir /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> subdirs /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> cuurrent dir /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> subdirs /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> cuurrent dir /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer >> subdirs /Volumes/T3/Dev/qt/worktrees/dev/qtsvg/tests/manual/examples/svgviewer .... Make Error at /Volumes/T3/Dev/qt/worktrees/dev/qtbase/cmake/QtPublicCMakeHelpers.cmake:103 (cmake_parse_arguments): Maximum recursion depth of 1000 exceeded Call Stack (most recent call first): /Volumes/T3/Dev/qt/worktrees/dev/qtbase/cmake/QtPublicCMakeHelpers.cmake:122 (_qt_internal_collect_buildsystem_targets) /Volumes/T3/Dev/qt/worktrees/dev/qtbase/cmake/QtPublicCMakeHelpers.cmake:122 (_qt_internal_collect_buildsystem_targets) /Volumes/T3/Dev/qt/worktrees/dev/qtbase/cmake/QtPublicCMakeHelpers.cmake:122 (_qt_internal_collect_buildsystem_targets) /Volumes/T3/Dev/qt/worktrees/dev/qtbase/cmake/QtPublicCMakeHelpers.cmake:122 (_qt_internal_collect_buildsystem_targets) ....
It's some bad interaction with SUBDIRECTORIES containing the current source dir when configuring in a nested in-source subdirectory (due to how we implemented qt-cmake-standalone-test).
One more reason to get rid of the script.
Upstream issue: https://gitlab.kitware.com/cmake/cmake/-/issues/25489
Attachments
Gerrit Reviews
| For Gerrit Dashboard: QTBUG-119998 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 524032,5 | CMake: Don't recurse with qt-cmake-standalone-test in-source dirs | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 525534,2 | CMake: Don't recurse with qt-cmake-standalone-test in-source dirs | 6.7 | qt/qtbase | Status: MERGED | +2 | 0 |
| 525761,2 | CMake: Don't recurse with qt-cmake-standalone-test in-source dirs | 6.6 | qt/qtbase | Status: MERGED | +2 | 0 |
| 525885,2 | CMake: Don't recurse with qt-cmake-standalone-test in-source dirs | tqtc/lts-6.5 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |