Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-120909

Improve SQL Browser Example - Coding style

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3: Somewhat important P3: Somewhat important
    • 6.7.0 Beta2, 6.8.0 FF
    • 6.6.3
    • SQL Support
    • None
    • 269082242 (dev), fb453fe28 (6.7)

      SQL Browser is an highlighted Application Example. Anyhow, its code base is not implementing best practices:

      • Uses Qt module headers instead of individual class headers
      • Code uses connect-by-name instead of explicit connect() (clazy-connect-by-name)
      • browser.cpp: Emit signal inside constructor (clazy-incorrect-emit)
      • Replace QObject::tr() antipattern with a more meaningful context
      • main.cpp: Use QCommandLineParser instead of manual argc, argv handling

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            chehrlic Christian Ehrlicher
            kkohne Kai Köhne
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes