Details
-
Bug
-
Resolution: Fixed
-
P3: Somewhat important
-
6.6.3
-
None
-
269082242 (dev), fb453fe28 (6.7)
Description
SQL Browser is an highlighted Application Example. Anyhow, its code base is not implementing best practices:
- Uses Qt module headers instead of individual class headers
- Code uses connect-by-name instead of explicit connect() (clazy-connect-by-name)
- browser.cpp: Emit signal inside constructor (clazy-incorrect-emit)
- Replace QObject::tr() antipattern with a more meaningful context
- main.cpp: Use QCommandLineParser instead of manual argc, argv handling
Attachments
Issue Links
- relates to
-
QTBUG-68661 Doc: Improve SQL Example: SQL Browser
-
- Closed
-
For Gerrit Dashboard: QTBUG-120909 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
530270,9 | Examples/sqlbrowser: improve coding style | dev | qt/qtbase | Status: MERGED | +2 | 0 |
532649,2 | Examples/sqlbrowser: improve coding style | 6.7 | qt/qtbase | Status: MERGED | +2 | 0 |