Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-121022

Miscompilation of condition

    XMLWordPrintable

Details

    • 9d8e78a2f (dev), 5d53ea984 (6.7), c24716c7f (6.6)

    Description

      When applying https://codereview.qt-project.org/c/qt/qtdeclarative/+/521753/11/src/qmltest/SignalSpy.qml#74

      and afterwards running

      tst_basic -input qtdeclarative/tests/auto/quickcontrols/controls/data/tst_abstractbutton.qml AbstractButton::test_mnemonic  

       

      a warning is printed:

      > TypeError: Cannot read property 'qtest_disconnectFromTarget' of null

      When running with QML_DISABLE_DISK_CACHE=1, the warning disappears, which is the expected outcome given that the if condition already checks that spy is not null.

       

      I suspect that we might assume that the id is never null, and thus optimize the check away?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ulherman Ulf Hermann
            fabiankosmale Fabian Kosmale
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes