Details
-
Bug
-
Resolution: Invalid
-
Not Evaluated
-
None
-
6.6, 6.7
-
None
-
All
Description
In a handful of places module config headers are included directly instead of via the module's global header as has clearly been the convention for a long time based on a survey of the codebase (see searches below).
The global headers pull in a number of important headers related to the module config headers.
QtCore
All inclusions of qtcore-config.h:
corelib/global/qtconfiginclude.h:19:#include <QtCore/qtcore-config.h> corelib/ipc/qtipccommon.h:8:#include <QtCore/qtcore-config.h>
All inclusions of qtcore-config_p.h:
corelib/global/qglobal_p.h:24:#include <QtCore/private/qtcore-config_p.h> network/ssl/qpassworddigestor.cpp:11:#include "qtcore-config_p.h" corelib/tools/qcryptographichash.cpp:109:#include "qtcore-config_p.h" corelib/ipc/qsystemsemaphore_p.h:25:#include "private/qtcore-config_p.h" corelib/ipc/qtipccommon_p.h:20:#include <private/qtcore-config_p.h>
On the other hand, all inclusions of qtconfiginclude.h (via other global headers):
Dozens of hits...
On the other hand, all inclusions of qglobal_p.h
Dozens of hits...
QtGui
All inclusions of qtgui-config.h:
gui/kernel/qtguiglobal.h:8:#include <QtGui/qtgui-config.h> gui/platform/unix/dbusmenu/qdbusmenuconnection.cpp:4:#include <QtGui/qtgui-config.h> gui/platform/unix/dbusmenu/qdbusmenuconnection_p.h:22:#include <QtGui/qtgui-config.h> gui/platform/macos/qcocoanativeinterface.mm:4:#include <QtGui/qtgui-config.h> plugins/platforms/windows/qwindowsopengltester.cpp:18:#include <QtGui/qtgui-config.h>
All inclusions of qtgui-config_p.h:
gui/kernel/qtguiglobal_p.h:20:#include <QtGui/private/qtgui-config_p.h> gui/text/windows/qwindowsdirectwritefontdatabase_p.h:19:#include <QtGui/private/qtgui-config_p.h> gui/text/windows/qwindowsfontdatabasebase_p.h:19:#include <QtGui/private/qtgui-config_p.h> gui/text/windows/qwindowsfontdatabase.cpp:14:#include <QtGui/private/qtgui-config_p.h> gui/text/windows/qwindowsfontenginedirectwrite_p.h:19:#include <QtGui/private/qtgui-config_p.h> gui/text/windows/qwindowsfontengine.cpp:20:#include <QtGui/private/qtgui-config_p.h> plugins/platforms/windows/qwindowsintegration.cpp:15:#include <QtGui/private/qtgui-config_p.h>
On the other hand, all inclusions of qtguiglobal.h:
Dozens of hits...
On the other hand, all inclusions of qtguiglobal_p.h:
Dozens of hits...