Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-121356

Suspicious comment in qchar.cpp possibly affecting unity builds

    XMLWordPrintable

Details

    • 62de01bf1 (dev), 4a3347202 (dev)

    Description

      qchar.cpp begins with:

      // Don't define it while compiling this module, or USERS of Qt will
// not be able to link.
#ifdef QT_NO_CAST_FROM_ASCII
#  undef QT_NO_CAST_FROM_ASCII
#endif
#ifdef QT_NO_CAST_TO_ASCII
#  undef QT_NO_CAST_TO_ASCII
#endif
#include "qchar.h"

      Note that qchar.cpp is not built individually; qstring.cpp includes it.

      Does this mean that qstring.cpp should be excluded from unity builds?
      Or (more likely) that code is irrelevant these days and can get removed?

      Attachments

        For Gerrit Dashboard: QTBUG-121356
        # Subject Branch Project Status CR V
        532619,3 QChar: unexport the class and export only the helper members dev qt/qtbase Status: MERGED +2 0
        533176,3 QString & QByteArray: ensure QT_NO_CAST_* are not defined on Windows dev qt/qtbase Status: MERGED +2 0

        Activity

          People

            qtbuildsystem Qt Build System Team
            peppe Giuseppe D'Angelo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes