Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: P1: Critical
Fix Version/s: 6.8.0 FF, 6.8
Affects Version/s: 6.8
Component/s: QML: Declarative and Javascript Engine
Labels:
None

Commits:
970828df9 (dev), bb3999a22 (dev), d6d224892 (dev), e19750538 (dev), b0d753ee3 (dev), bdb624659 (dev), 241b8693d (dev)

It seems that the main use case for black allocations was preventing objects from getting swept by the gc https://codereview.qt-project.org/c/qt/qtdeclarative/+/320532 . But this was only possible because the gc lacked an active write barrier.

Now that we do have a write barrier, we should revisit this (as it introduces gotchas in a few places).

relates to

QTBUG-123426 Assert in qml engine "Q_ASSERT(m()->internalClass->vtable)"

Closed

QTBUG-129241 Crash at QV4::Value::as<T>

Closed

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-121910
#	Subject	Branch	Project	Status	CR	V
537176,35	ArrayData/MemberData: Prove Fixed gc interaction	dev	qt/qtdeclarative	Status: MERGED	+2	0
538933,26	Prepare for white allocations during gc (9/9): ExecutableCompilationUnit	dev	qt/qtdeclarative	Status: MERGED	+2	0
538934,25	Prepare for white allocations during gc (1/9): Write barrier for Lookups	dev	qt/qtdeclarative	Status: MERGED	+2	0
538936,25	Prepare for white allocations during gc (2/9): QQmlVMEMetaObject	dev	qt/qtdeclarative	Status: MERGED	+2	0
538937,25	Prepare for white allocation during gc(3/9): Function	dev	qt/qtdeclarative	Status: MERGED	+2	0
538938,3	WIP: Prepare for white allocation during gc (x/n): QV4::ObjectWrapper	dev	qt/qtdeclarative	Status: ABANDONED	-2	0
538944,26	Prepare for white allocations during gc(6/9): Engine setup	dev	qt/qtdeclarative	Status: MERGED	+2	0
538945,26	QV4 garbage collection: Allocate white during gc run	dev	qt/qtdeclarative	Status: MERGED	+2	0
552452,1	WIP: Prepare for white allocations during gc (1/9): Write barrier for Lookups	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552453,1	WIP: Prepare for white allocations during gc (2/9): QQmlVMEMetaObject	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552454,1	WIP: Prepare for white allocation during gc(3/9): Function	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552457,1	WIP: Prepare for white allocations during gc(6/9): Engine setup	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552460,1	WIP: Prepare for white allocations during gc (9/9): ExecutableCompilationUnit	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552461,1	WIP: QV4 garbage collection: Allocate white during gc run	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0
552466,1	WIP: ArrayData/MemberData: Prove Fixed gc interaction	tqtc/lts-6.5	qt/tqtc-qtdeclarative	Status: DEFERRED	-2	0