Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-121933

DOM: Simplify ScriptExpression

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • QML: Tooling
    • None

    Description

      ScriptExpression has somewhat unclear / coupled interface. There are m_code, m_codeStr, which are being sometimes protected by mutex, sometimes not. It seems that preCode and postCode are not used at all. Also there are functions like setCode, which instantiate a parser and JSEngine and doing lots of things, sometimes quite non-obvious.

      It would be nice to figure out and simplify the workflow when using them. That requires a bit of time investigating and potentially refactoring.

       

      Some more details / context: 
      Dmitrii Akshintsev: Hi everyone, I have a somewhat follow-up / related question to… 
      posted in Foundation / QML at Feb 5, 3:01:24 PM
       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qtqmlteam Qt Qml Team User
            dima.a Dmitrii Akshintsev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes