Details
-
Task
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
None
-
None
-
ef28c9d7c (dev), 4970889fd (6.7)
Description
Acceptance criteria:
- Rename the actual QtTest test class to `tst_QWebChannel` or something similar.
- Update the friend declaration to the idiomatic way so the test class doesn't get a different name in -qt-namesspace builds:
- forward-declare the tst_ class outside QT_BEGIN_NAMEPACE
- use friend class ::tst_X; (the :: is important)
Attachments
Gerrit Reviews
For Gerrit Dashboard: QTBUG-122927 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
544644,2 | QWebChannel: give friendship to tst_bench_QWebChannel the idiomatic way | 6.7 | qt/qtwebchannel | Status: MERGED | +2 | 0 |
544659,2 | QWebChannel: give friendship to tst_bench_QWebChannel the idiomatic way | dev | qt/qtwebchannel | Status: MERGED | +2 | 0 |